1018337 - page title for neterror pages is used for the undo close tab super toast

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

1) Load http://foo.mozilla.org or other non-existent page
2) Swipe or press the close button for the tab
3) super toast saying "Closed Problem loading page | Undo"

Similar issues around invalid certificates as well. https://cacert.org for a testcase.

Maybe we should use the url or domain?

Comment 1

[:Margaret Leibovic]

Using the URL sounds like a good idea.

wesj, is there a way for us to just generically know if a page is an error page?

Comment 2

[Aaron Train [:aaronmt]]

Because someone will ask, Chrome uses the URL on errors too

Comment 3

[:Margaret Leibovic]

In bug 1018661, I'm changing this undo close tab toast to use the title/url we store in session store, rather than the one in the active browser.

So, the solution to this bug would be to not store net error titles in session store, which is probably an overall win anyway, so they won't show up in the "Recent Tabs" panel I'm working on in bug 1004850.

Comment 4

[:Margaret Leibovic]

(In reply to :Margaret Leibovic from comment #3)

> So, the solution to this bug would be to not store net error titles in
> session store, which is probably an overall win anyway, so they won't show
> up in the "Recent Tabs" panel I'm working on in bug 1004850.

Actually, it looks like we already do this. So this bug should be fixed when bug 1018661 lands.

Comment 5

[Wesley Johnston (:wesj)]

Java knows about error pages using errorType:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/Tab.java#306

javascript seems to know using document.documentURI

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

We used to send the documentURI.spec to Java in the Content:LocationChanged message:
http://hg.mozilla.org/mozilla-central/diff/ceffbd680e2c/mobile/android/chrome/content/browser.js

But we don't anymore
https://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#4053

Comment 7

[:Margaret Leibovic]

Luckily we don't need to worry about this, since session store gets its session history from docshell, and that doesn't save any error page title. So this will automatically work once bug 1018661 lands.

Comment 8

[:Margaret Leibovic]

This should be fixed by bug 1018661.

Comment 9

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in build 32.0a1 (2014-06-06)
Device: Asus Transformer TF101 (Android 4.0.3)

Comment 10

[Kevin Brosnan [Ex-Mozilla]]

I don't see the url just a notice that says closed tab.

Comment 11

[:Margaret Leibovic]

That's an expected change made in bug 1020730.

The bug here is about the fact that we showed the error page title, which we still aren't doing, so this bug is still fixed.

Comment 12

[Kevin Brosnan [Ex-Mozilla]]

Verified then. It was not clear from the comments that we were not going to use the URL or domain suggestion.