1018377 - Update trychooser for Android 2.3

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Geoff Brown [:gbrown]]

trychooser is missing some test jobs introduced for Android 2.3, such as plain-reftest-9 ... plain-reftest-12.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: update trychooser for Android 2.3 and Android x86

I opted to change "Android 2.2" to "Android 2.3" rather than "Android 2.2/2.3", in hopes of a rapid removal of 2.2.

New tests for Android 2.3:
  plain-reftest-9
  plain-reftest-10
  plain-reftest-11
  plain-reftest-12
  xpcshell-1
  xpcshell-2
  xpcshell-3

jsreftest-4, jsreftest-5, and jsreftest-6 were previously marked x86 only, but are not currently running for Android x86. Now they *are* needed for Android 2.3, so I removed the "only x86" comments.

Similarly, reftest-9, reftest-10, crashtest-1, crashtest-2, and crashtest-3 were x86 only, but none of them are running for Android x86. crashtest-1 and crashtest-2 *are* needed for Android 2.3, so I removed the "only x86" comments and removed crashtest-3.

There were "not x86" comments for robocop-3, robocop-4, and robocop-5, but robocop-3 is actually valid for Android x86. I opted to remove the 2 remaining valid x86 comments: If we try to distinguish which jobs are valid on x86, we should do the same for 2.3 vs 4.0, and I think that is just too complicated.

Finally, I noticed that "xpcshell" was in both the desktop section and the Android-only section, so I removed it from the Android-only section.

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 8431808 [details] [diff] [review]
update trychooser for Android 2.3 and Android x86

Review of attachment 8431808 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm :-)

Comment 3

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/build/tools/rev/f0d531faff8d

Comment 4

[Geoff Brown [:gbrown]]

Attachment: add more entries for more Android/B2G reftest chunks

In bug 1023314, we add more chunks for Android 2.3 and B2G reftests: 

 - there are now 16 Android 2.3 reftest chunks
 - on next reconfig there will be 20 B2G reftest chunks

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 8439308 [details] [diff] [review]
add more entries for more Android/B2G reftest chunks

Yey for the day when this is generated from a central json manifest :-)

Comment 6

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/build/tools/rev/7401eb2160cf

Comment 7

[Simone Bruno [:simone]]

Is this ready to be deployed then?

Comment 8

[Geoff Brown [:gbrown]]

Yes!

Comment 9

[Simone Bruno [:simone]]

trychooser change is now live - please verify at http://trychooser.pub.build.mozilla.org/

Comment 10

[Geoff Brown [:gbrown]]

That looks fine. Thanks much.