1018430 - UI Telemetry for page context menu

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

We're not tracking how we use our web content context menu items, so we should add that - in particular, we're also interested in how often people open private tabs from the web context menu.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: uitelemetry-page-contextmenu v0.1

Sadly, we do not have an easy way to do this in a single place, like we do with Java contextmenus. I tried to make this look as much like the Java "action.1" events as possible. This might not be all the contextmenu items, since we can add them from anywhere.

I'll look for more and post a second patch if I find some.

Comment 2

[Chenxia Liu [:liuche]]

Comment on attachment 8440818 [details] [diff] [review]
uitelemetry-page-contextmenu v0.1

Review of attachment 8440818 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I punted on doing this because it was required adding probes all over the place. But I don't think there's another way of doing it, unfortunately.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/fx-team/rev/513f7006ab6b

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/513f7006ab6b

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8440818 [details] [diff] [review]
uitelemetry-page-contextmenu v0.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Allows collecting more telemetry data
Testing completed (on m-c, etc.): Working on m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 6

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/823d7509bf7b

Comment 7

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/874c035003ac