Closed Bug 1018433 Opened 8 years ago Closed 8 years ago

Add telemetry for "undo close tab"

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 32

People

(Reporter: liuche, Assigned: liuche)

References

Details

Attachments

(1 file)

Add telemetry for "Undo close tab," added by bug 701725.
Didn't add a session because we currently have no way of detecting when a toast has expired, so we have no way to close it.

I thought about whether "toast" as a method was too specific, but I can see us using it in supertoasts in the future, and it would be good to distinguish it from an undo button, which is another validly different method for exposing undo. Feel free to push back though!
Assignee: nobody → liuche
Status: NEW → ASSIGNED
Attachment #8433742 - Flags: review?(mark.finkle)
Comment on attachment 8433742 [details] [diff] [review]
Patch: Add telemetry for undo close tab

Makes sense to me.

>diff --git a/mobile/android/chrome/content/browser.js b/mobile/android/chrome/content/browser.js

>           callback: function() {
>             let ss = Cc["@mozilla.org/browser/sessionstore;1"].getService(Ci.nsISessionStore);
>+            UITelemetry.addEvent("undo.1", "toast", null, "closetab");
>             ss.undoCloseTab(window, 0);

Could you move the addEvent above the let ss = ... ? Just hurts my OCD to split the code.

>            UITelemetry.addEvent("undo.1", "toast", null, "closetab");
>
>            let ss = Cc["@mozilla.org/browser/sessionstore;1"].getService(Ci.nsISessionStore);
>            ss.undoCloseTab(window, 0);
Attachment #8433742 - Flags: review?(mark.finkle) → review+
Reordered Telemetry line.

https://hg.mozilla.org/integration/fx-team/rev/b2b3a983b1a9
Target Milestone: --- → Firefox 32
https://hg.mozilla.org/mozilla-central/rev/b2b3a983b1a9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.