1018433 - Add telemetry for "undo close tab"

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

Add telemetry for "Undo close tab," added by bug 701725.

Comment 1

[Chenxia Liu [:liuche]]

Attachment: Patch: Add telemetry for undo close tab

Didn't add a session because we currently have no way of detecting when a toast has expired, so we have no way to close it.

I thought about whether "toast" as a method was too specific, but I can see us using it in supertoasts in the future, and it would be good to distinguish it from an undo button, which is another validly different method for exposing undo. Feel free to push back though!

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8433742 [details] [diff] [review]
Patch: Add telemetry for undo close tab

Makes sense to me.

>diff --git a/mobile/android/chrome/content/browser.js b/mobile/android/chrome/content/browser.js

>           callback: function() {
>             let ss = Cc["@mozilla.org/browser/sessionstore;1"].getService(Ci.nsISessionStore);
>+            UITelemetry.addEvent("undo.1", "toast", null, "closetab");
>             ss.undoCloseTab(window, 0);

Could you move the addEvent above the let ss = ... ? Just hurts my OCD to split the code.

>            UITelemetry.addEvent("undo.1", "toast", null, "closetab");
>
>            let ss = Cc["@mozilla.org/browser/sessionstore;1"].getService(Ci.nsISessionStore);
>            ss.undoCloseTab(window, 0);

Comment 3

[Chenxia Liu [:liuche]]

Reordered Telemetry line.

https://hg.mozilla.org/integration/fx-team/rev/b2b3a983b1a9

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b2b3a983b1a9