Closed Bug 1018589 Opened 7 years ago Closed 6 years ago

Can't add RSS feed with Cyrillic URL -> support idn urls for feeds

Categories

(MailNews Core :: Feed Reader, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 33.0

People

(Reporter: alex3kov, Assigned: alta88)

References

()

Details

Attachments

(2 files, 1 obsolete file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140514164129

Steps to reproduce:

Tried to subscribe to http://партиявеликоеотечество.рф/feed/
It works fine in Firefox Live Bookmarks.


Actual results:

Received error "The Feed URL could not be found."


Expected results:

Successfully subscribing to a feed.
Attached patch idn.patch (obsolete) — Splinter Review
Value has been deprecated for ValueUTF8 for nsIRDFResource for a long time, and it finally matters with idn urls.
Assignee: nobody → alta88
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #8432274 - Flags: review?(mkmelin+mozilla)
Assignee: alta88 → nobody
Component: Untriaged → Feed Reader
OS: Linux → All
Product: Thunderbird → MailNews Core
Hardware: x86_64 → All
Summary: Can't add RSS feed with Cyrillic URL → Can't add RSS feed with Cyrillic URL -> support idn urls for feeds
Assignee: nobody → alta88
It seems this fixes the subscription, but every message (view as webpage) can't connect as encoding seems messed up.
Tested http://партиявеликоеотечество.рф/za-stalingrad

"www.паÑÑиÑвеликоеоÑеÑеÑÑво.ÑÑ could not be found. Please check the name and try again."
Attached patch idn.patchSplinter Review
this fixes the url for web pages, but it seems like MsgHdrToMimeMessage should do this sort of thing generically.
Attachment #8432274 - Attachment is obsolete: true
Attachment #8432274 - Flags: review?(mkmelin+mozilla)
Attachment #8439925 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8439925 [details] [diff] [review]
idn.patch

Review of attachment 8439925 [details] [diff] [review]:
-----------------------------------------------------------------

Works fine now, thx! r=mkmelin
Attachment #8439925 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/57bcf6cc9e8a
Status: NEW → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 33.0
Comment on attachment 8625281 [details]
screenshot - causing false charset with German umlauts

This new feature causes problems rendering German umlauts in de dc:creator field, see attachement. The charset of the sender's address seems to be wrong.
Thanks for help on this matter.
I am seeing a similar thing whit the feed from the Danish newspaper Dagbladet Børsen. The character ø is displayed with a ?.
http://borsen.dk/services/newsfeed/rss/
I don't think this bug fix was implemented the right way, so I reopen it.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
bug 1023285.
Status: REOPENED → RESOLVED
Closed: 7 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.