Closed
Bug 1018680
Opened 10 years ago
Closed 10 years ago
Fix jsd_xpc.cpp warning and mark js/ductwork, js/jsd, and js/xpconnet as FAIL_ON_WARNINGS
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(1 file)
|
3.02 KB,
patch
|
ejpbruel
:
review+
|
Details | Diff | Splinter Review |
After bug 880330 changed ContextOptions from a bitfield to a struct, jsdContext::SetOptions() is now comparing privateIsNSISupports() bool (0 or 1) against JSOPTION_PRIVATE_IS_NSISUPPORTS bit flag (3), which will never be equal: js\jsd\jsd_xpc.cpp(1684) : warning C4805: '!=' : unsafe mix of type 'bool' and type 'uint32_t' in operation Also mark some more warning-free js directories as FAIL_ON_WARNINGS: js/ductwork, js/jsd, js/xpconnet/tests, and js/xpconnect/wrappers.
Attachment #8432187 -
Flags: review?(ejpbruel)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8432187 [details] [diff] [review] fix-jsd-warning.patch Review of attachment 8432187 [details] [diff] [review]: ----------------------------------------------------------------- Good catch!
Attachment #8432187 -
Flags: review?(ejpbruel) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8f0b05bd50c
status-firefox32:
--- → wontfix
status-firefox33:
--- → fixed
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d8f0b05bd50c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•