101890 - break linkage from transformiix to layout

Status: VERIFIED FIXED

(Core :: XSLT, defect, P4)

Description

[Jon Smirl]

patch removes linkage from transformiix to layout. transformiix was using 
layoutcid.h to define NS_DOM_IMPLEMENTATION_CID. DOMImplementation actually is 
implementent in contentcid.h. layoutcid.h should probably not include a define 
for it.

Also removed old raptor references from makefiles.

Comment 1

[Jon Smirl]

Attachment: remove layout linkage

Comment 2

[Axel Hecht]

Comment on attachment 51037 [details] [diff] [review]
remove layout linkage

r=[e-mail], thanks for doing this

Comment 3

[Axel Hecht]

Comment on attachment 51037 [details] [diff] [review]
remove layout linkage

pfff on me, that patch doesn't change
the Makefile.in's yet

Comment 4

[Alec Flett]

Comment on attachment 51037 [details] [diff] [review]
remove layout linkage

actually, can you remove -I entries in LINCS that refer to $(PUBLIC)\<something>? I thought I caught most of those but we're trying to avoid using LINCS for anything other than fairly local (i.e. relative) includes

Comment 5

[Jon Smirl]

As far as I can tell the only thing still using raptor is the SVG support. I 
just removed them because I thought what they were referencing was gone. What 
would be a reason for keeping them?

Comment 6

[Alec Flett]

raptor is dead - it isn't used anywhere.. I meant if you could remove the
"-I$(PUBLIC)\xpcom" and similar entries from the LINCS lines

Comment 7

[Axel Hecht]

How did this work for you?
mozilladom.h include nsIDocument.h which includes nslayout.h.

Hrm.

Comment 8

[Jon Smirl]

I agree, patch fails now. Something has changed in the last three week making 
it invalid. I'll try and fix it again.

Comment 9

[Jon Smirl]

Ok, there is nothing wrong with this patch. I do need to make a new bug for 
removing the unneeded linkage between nsIDocument.h and nslayout.h. I'll attach 
it to this one in a few minutes.

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

can we really do this now that the outputhandler does some specialhandling of
for style-elements? Or is that done by just talking to content?

Comment 11

[Peter Van der Beken [:peterv]]

Taking.

Comment 12

[Peter Van der Beken [:peterv]]

Attachment: Remove layout dependency

I cleaned up some REQUIRES, removed Nodestack.* since it's not used anywhere
and cleaned up some includes. Looking for review.

Comment 13

[Peter Van der Beken [:peterv]]

(You can ignore the makefile.win changes, I removed them from my tree.)

Comment 14

[Peter Van der Beken [:peterv]]

Attachment: Remove layout dependency

Also remove unused NodeStack and JavaScript linkage on Mac.

Comment 15

[Axel Hecht]

Comment on attachment 95777 [details] [diff] [review]
Remove layout dependency

r=[e-mail]

Comment 16

[Johnny Stenback (:jst)]

Comment on attachment 95777 [details] [diff] [review]
Remove layout dependency

sr=jst

Comment 17

[Peter Van der Beken [:peterv]]

Checked in.

Comment 18

[Axel Hecht]

verified.
Note: the widget deps comes from nsIDocument, in case someone else but me 
wonders