1019148 - On right mouse click, Eyedropper should do nothing

Status: NEW

(DevTools :: Inspector, defect, P3)

Description

[jaramat]

Currently, when the Eyedropper is active, the only way to "drop out" of it without copying the color under it is to hit the Escape key. All three mouse buttons are assigned the same function - copy color.

This should be changed. For example, a popular screen grabbing tool FastStone Capture handles both Right button and Middle button as "Cancel". A user who uses the Eyedropper in Nightly is expected to expect this behavior as well.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

filter on CLIMBING SHOES

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Matteo, does it looks relevant to you ?

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

I think that once Bug 1262439 lands, this will be less relevant; since it would be possible disable the eye dropper by clicking to the tool's icon too – so the keystroke won't be the only way to do so. I'm a bit afraid on changing the current behavior: adding different functionalities to mouse's buttons is always a bit hard to discover by themselves – there is no UI that indicates what's changed. So, definitely a P3, maybe a WONTFIX with Bug 1262439; but I would like to ask to Helen what she think about it – maybe having the right click button as "exit" is a common action in such tools and the designers are well-aware, in that case we could safely change the current behavior.

Comment 4

[Helen V. Holmes (:helenvholmes) (:✨)]

In testing a few other tools (Adobe programs, Sketch, Sip) it seems that right-click does nothing, but it also doesn't exit the tool.

The current implementation of Escape, clicking to copy, and hitting the tool icon again to exit the tool seem consistent with other tools on the market.

I think there is a bug here, but only that right-click copies the color. And that I agree with Mateo is a P3.