1019157 - In-content prefs: Huge Application pane with a lot of applications.

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Richard Marti (:Paenglab)]

Attachment: Huge Applications pane

With a lot of applications the pane becomes really tall. The pane in my Nightly has a height of 2809px.

I think we should limit the height to 600px.

Comment 1

[Richard Marti (:Paenglab)]

Michael, what do you think, should we leave it as it is or limit the listboxes height to something like 600px or less to give the possibility to see the full pane and let the listbox have the scrollbar instead of the pane. The old dialog prefs has the panes height limited and the scrollbar on the listbox.

Comment 2

[Richard Marti (:Paenglab)]

Michael, would be a box height of 438px with showing 10 entries okay? When where are more than 10 then, the scrollbar appears in the listbox.

Comment 3

[Michael Maslaney [:mmaslaney] ([e-mail])]

That works, thanks Richard.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: handlersViewHeight.patch

Limit the height to 10 items.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8440797 [details] [diff] [review]
handlersViewHeight.patch

Review of attachment 8440797 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/incontentprefs/preferences.css
@@ +687,5 @@
>    border-radius: 2px;
>    background-color: #FBFBFB;
>    overflow-y: auto;
> +  /* 10 items + listheader + border */
> +  height: 438px;

By default on my Win8.1 machine, I see just under 12 rows in the old preferences window. I also don't think we should try for an integer number of rows, as showing a partial row at the bottom can is a nice hint for people to see that there is more content to scroll to.

r=me if you change this to height:500px;

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Patch for check-in

Changed to 500px.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/16b3197fe35f

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/16b3197fe35f

Comment 9

[Guilherme Lima]

I'm sorry for using this space to ask a question, but isn't possible to make height variable to what is visible to the user? I mean, 500px, 600px, 400px... each computer has one height. On my case now I have 2 scrollbars, one for the page and one for the applications.

Comment 10

[Dão Gottwald [:dao]]

(In reply to Guilherme Lima from comment #9)
> On my case now I have 2 scrollbars, one for the page and one for the applications.

Can you please file a new bug on this? Thanks.