Closed
Bug 1019218
Opened 10 years ago
Closed 10 years ago
Eclipse does not rebuild org.mozilla.gecko.R when editing resources
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
All
Android
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla32
People
(Reporter: nalexander, Assigned: nalexander)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
2.68 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
This is particularly important when changing strings.xml.in or changing the set of Android identifiers; without this, the Fennec code referencing org.mozilla.gecko.R is not updated. This can either lead to compilation failures, or missing resources at run-time, leading to strange crashes on start-up.
Assignee | ||
Comment 1•10 years ago
|
||
This is particularly important when changing strings.xml.in or changing the set of Android identifiers; without this, the Fennec code referencing R is not updated. This can either lead to compilation failures, or missing resources at run-time, leading to strange crashes on start-up. liuche, feel free to rubber-stamp or redirect. I know you use Eclipse (some of the time?), so you're valuable as a tester/person who might care to know that this should be more reliable now.
Attachment #8432768 -
Flags: review?(liuche)
Comment 2•10 years ago
|
||
Comment on attachment 8432768 [details] [diff] [review] Update org.mozilla.gecko.R when resources are changed in Eclipse. r=liuche Thanks for letting me know! Seems fine to me if it works, but I'm going to pass this on to rnewman.
Attachment #8432768 -
Flags: review?(liuche) → review?(rnewman)
Comment 3•10 years ago
|
||
Comment on attachment 8432768 [details] [diff] [review] Update org.mozilla.gecko.R when resources are changed in Eclipse. r=liuche Review of attachment 8432768 [details] [diff] [review]: ----------------------------------------------------------------- This seems sane to me, but I have a small worry that one of these targets will cause .aapt.deps to be modified, and the build will be endlessly retriggered. Assuage my fears?
Attachment #8432768 -
Flags: review?(rnewman) → review+
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Richard Newman [:rnewman] from comment #3) > Comment on attachment 8432768 [details] [diff] [review] > Update org.mozilla.gecko.R when resources are changed in Eclipse. r=liuche > > Review of attachment 8432768 [details] [diff] [review]: > ----------------------------------------------------------------- > > This seems sane to me, but I have a small worry that one of these targets > will cause .aapt.deps to be modified, and the build will be endlessly > retriggered. Assuage my fears? A reasonable fear. |make .aapt.deps| is idempotent, so the only concern is a loop between Make and Eclipse. Eclipse does not "see" .aapt.deps, so such a loop should not occur possible. However, it could be that there's a loop between generating strings.xml and Eclipse building; but I'm not seeing it in practice. It's pretty easy to screw up strings.xml and have to fix-and-clean; but that's just how this thing works :)
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/36bc7df3eed5
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/36bc7df3eed5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 32 → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•