1019218 - Eclipse does not rebuild org.mozilla.gecko.R when editing resources

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Nick Alexander :nalexander [he/him]]

This is particularly important when changing strings.xml.in or changing the set of Android identifiers; without this, the Fennec code referencing org.mozilla.gecko.R is not updated.  This can either lead to compilation failures, or missing resources at run-time, leading to strange crashes on start-up.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Update org.mozilla.gecko.R when resources are changed in Eclipse. r=liuche

This is particularly important when changing strings.xml.in or changing
the set of Android identifiers; without this, the Fennec code
referencing R is not updated.  This can either lead to compilation
failures, or missing resources at run-time, leading to strange crashes
on start-up.

liuche, feel free to rubber-stamp or redirect.  I know you use Eclipse
(some of the time?), so you're valuable as a tester/person who might
care to know that this should be more reliable now.

Comment 2

[Chenxia Liu [:liuche]]

Comment on attachment 8432768 [details] [diff] [review]
Update org.mozilla.gecko.R when resources are changed in Eclipse. r=liuche

Thanks for letting me know! Seems fine to me if it works, but I'm going to pass this on to rnewman.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8432768 [details] [diff] [review]
Update org.mozilla.gecko.R when resources are changed in Eclipse. r=liuche

Review of attachment 8432768 [details] [diff] [review]:
-----------------------------------------------------------------

This seems sane to me, but I have a small worry that one of these targets will cause .aapt.deps to be modified, and the build will be endlessly retriggered. Assuage my fears?

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to Richard Newman [:rnewman] from comment #3)
> Comment on attachment 8432768 [details] [diff] [review]
> Update org.mozilla.gecko.R when resources are changed in Eclipse. r=liuche
> 
> Review of attachment 8432768 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This seems sane to me, but I have a small worry that one of these targets
> will cause .aapt.deps to be modified, and the build will be endlessly
> retriggered. Assuage my fears?

A reasonable fear.  |make .aapt.deps| is idempotent, so the only concern is a loop between Make and Eclipse.  Eclipse does not "see" .aapt.deps, so such a loop should not occur possible.

However, it could be that there's a loop between generating strings.xml and Eclipse building; but I'm not seeing it in practice.  It's pretty easy to screw up strings.xml and have to fix-and-clean; but that's just how this thing works :)

Comment 5

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/36bc7df3eed5

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/36bc7df3eed5