Implement getComputedStyle() for float property

RESOLVED FIXED in mozilla0.9.5

Status

()

Core
DOM: CSS Object Model
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: glazou, Assigned: glazou)

Tracking

(Blocks: 1 bug)

Trunk
mozilla0.9.5
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

16 years ago
getComputedStyle() is not implemented for the float property.
(Assignee)

Updated

16 years ago
Blocks: 77705
Target Milestone: --- → mozilla0.9.5
(Assignee)

Comment 1

16 years ago
Created attachment 51056 [details] [diff] [review]
patch v1.0
(Assignee)

Comment 2

16 years ago
patch attached, ready for reviews (I also did a little cleanup/reordering of some*
lines)
Status: NEW → ASSIGNED

Comment 3

16 years ago
CC'ing bz who's the new happy owner of getComputedStyle
Comment on attachment 51056 [details] [diff] [review]
patch v1.0

r=bzbarsky if you add that to the right place in queryableProperties (please attach a new patch once you do that....)
Attachment #51056 - Flags: review+
Blocks: 42417
Keywords: patch, review
Comment on attachment 51056 [details] [diff] [review]
patch v1.0

sr=jst with the bad next-line argument indentation fixed.
Attachment #51056 - Flags: superreview+
(Assignee)

Comment 6

16 years ago
Created attachment 51202 [details] [diff] [review]
patch v1.1 in answer to bzbarsky (contains also next-line indent cleanup of the file)
(Assignee)

Comment 7

16 years ago
checked in trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
argh. reopening....

-nsComputedDOMStyle::GetCssFloat(nsAWritableString& aCssFloat)
+nsComputedDOMStyle::GetFloat(nsAWritableString& aFloat)

That's no good...  missed that my first look at the file.  :(

The property as defined by
http://www.w3.org/TR/2000/REC-DOM-Level-2-Style-20001113/css.html#CSS-CSS2Properties
is called cssFloat (since "float" is a reserved word in some languages).

glazou, would you care to attach a fixup patch?  And my apologies for missing
this the first time... 
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 9

16 years ago
Created attachment 51216 [details] [diff] [review]
fixup patch; boris, can you please rs= ?
(Assignee)

Comment 10

16 years ago
fixed with rs=jst on #mozilla
Status: REOPENED → RESOLVED
Last Resolved: 16 years ago16 years ago
Resolution: --- → FIXED
Thanks for the fixup... my apologies for the cruddy review.... :(
You need to log in before you can comment on or make changes to this bug.