1019287 - nsLineLayout fails to build if NOISY_BLOCKDIR_ALIGN is defined

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[sgbowen]

STR:
1. Add "#define NOISY_BLOCKDIR_ALIGN" to the top of nsLineLayout.cpp
2. Try to build

Expected results:
No build error

Actual results:
 {
 0:11.04 In file included from /home/sgbowen/builds/mozilla-central/layout/generic/nsLineLayout.h:20:0,
 0:11.04                  from /home/sgbowen/builds/mozilla-central/layout/generic/nsLineLayout.cpp:11:
 0:11.04 /home/sgbowen/builds/mozilla-central/layout/generic/nsLineBox.h: In member function ‘void nsLineLayout::BlockDirAlignLine()’:
 0:11.04 /home/sgbowen/builds/mozilla-central/layout/generic/nsLineBox.h:584:24: error: ‘mozilla::LogicalRect nsLineBox::mBounds’ is private
 0:11.04    mozilla::LogicalRect mBounds;
 0:11.04                         ^
 0:11.04 /home/sgbowen/builds/mozilla-central/layout/generic/nsLineLayout.cpp:1471:15: error: within this context
 0:11.04      mLineBox->mBounds.IStart(lineWM), mLineBox->mBounds.BStart(lineWM),
 0:11.04                ^
 0:11.04 In file included from /home/sgbowen/builds/mozilla-central/layout/generic/nsLineLayout.h:20:0,
 0:11.04                  from /home/sgbowen/builds/mozilla-central/layout/generic/nsLineLayout.cpp:11:
 0:11.04 /home/sgbowen/builds/mozilla-central/layout/generic/nsLineBox.h:584:24: error: ‘mozilla::LogicalRect nsLineBox::mBounds’ is private
 0:11.04    mozilla::LogicalRect mBounds;
 0:11.04                         ^
 0:11.04 /home/sgbowen/builds/mozilla-central/layout/generic/nsLineLayout.cpp:1471:49: error: within this context
 0:11.04      mLineBox->mBounds.IStart(lineWM), mLineBox->mBounds.BStart(lineWM),
 0:11.04                                                  ^
 0:11.04 In file included from /home/sgbowen/builds/mozilla-central/layout/generic/nsLineLayout.h:20:0,
 0:11.04                  from /home/sgbowen/builds/mozilla-central/layout/generic/nsLineLayout.cpp:11:
 0:11.04 /home/sgbowen/builds/mozilla-central/layout/generic/nsLineBox.h:584:24: error: ‘mozilla::LogicalRect nsLineBox::mBounds’ is private
 0:11.04    mozilla::LogicalRect mBounds;
 0:11.04                         ^
 0:11.04 /home/sgbowen/builds/mozilla-central/layout/generic/nsLineLayout.cpp:1472:15: error: within this context
 0:11.04      mLineBox->mBounds.ISize(lineWM), mLineBox->mBounds.BSize(lineWM),
 0:11.04                ^
 0:11.04 In file included from /home/sgbowen/builds/mozilla-central/layout/generic/nsLineLayout.h:20:0,
 0:11.04                  from /home/sgbowen/builds/mozilla-central/layout/generic/nsLineLayout.cpp:11:
 0:11.04 /home/sgbowen/builds/mozilla-central/layout/generic/nsLineBox.h:584:24: error: ‘mozilla::LogicalRect nsLineBox::mBounds’ is private
 0:11.04    mozilla::LogicalRect mBounds;
 0:11.04                         ^
 0:11.04 /home/sgbowen/builds/mozilla-central/layout/generic/nsLineLayout.cpp:1472:48: error: within this context
 0:11.04      mLineBox->mBounds.ISize(lineWM), mLineBox->mBounds.BSize(lineWM),
 0:11.04                                                 ^
 0:11.21 In the directory  /home/sgbowen/builds/obj/layout/generic
}

Comment 1

[sgbowen]

Attachment: Fix

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8432873 [details] [diff] [review]
Fix

r=me

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Thanks for the patch, Susanna! One request, can we please get a Try run for this before pushing? Thanks :)

Comment 4

[Daniel Holbert [:dholbert]]

Ah, I forgot about that rule, yeah.  I'll coordinate with Susanna over IRC to get a Try run for this.

(Technically, this is NPOTB since it's in a block of #ifdeffed-out code [which currently doesn't even compile, and which this patch changes to make compile], so it might be arguable that a Try run is unnecessary here. Still probably worth triggering one to get the hang of it, though.)

Comment 5

[Daniel Holbert [:dholbert]]

Actually, per IRC, sounds like we can skip the Try run since this is NPOTB (not part of the [default] build).  Adding back checkin-needed.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ad3d4ab088e

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ad3d4ab088e