1019292 - Balrog release submissions should adjust productName as needed

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [tools] .lower() .lower() .lower() do the limbo!

We're creating urls like
   https://www.mozilla.org/en-US/Firefox/30.0/releasenotes/
instead of
   https://www.mozilla.org/en-US/firefox/30.0/releasenotes/

AFAIK we don't have any B2G use case here, so it's 50/50 whether you .lower() in the function or when you call it.

Comment 1

[[e-mail] (:bhearsum)]

Comment on attachment 8432878 [details] [diff] [review]
[tools] .lower() .lower() .lower()  do the limbo!

Review of attachment 8432878 [details] [diff] [review]:
-----------------------------------------------------------------

I've been trying to err on the side of pushing .lower() and .capitalize() as far up the call stack as possible (which is admittedly difficult). Is there a reason not to put this in submitter/cli.py instead?

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

That's fine. Turns out there are other things to fix too.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [tools] Fixes paths for test updates too

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8433658 [details] [diff] [review]
[tools] Fixes paths for test updates too

https://hg.mozilla.org/build/tools/rev/524bdee72020