1019334 - Remove TypedArray's (JSObject*) constructor overload

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jeff Walden [:Waldo]]

TypedArray's object-taking constructor is sort of broken.  Remove it.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8432945 [details] [diff] [review]
Patch

Why not just have the one-arg ctor call Init() instead of making all the consumers do it?

Comment 3

[Jeff Walden [:Waldo]]

Because then people have to check inited() themselves, manually, and remember to do it.  Whereas if Init() is required to do anything, there's an existing call that must be made, and the burden of checking its return value is somewhat more obvious.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8432945 [details] [diff] [review]
Patch

OK, that's fair.  I had mostly designed this constructor for those cases where you're MOZ_ASSERTing inited, but alright.

Comment 5

[Jeff Walden [:Waldo]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ae8f9e034ad

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6ae8f9e034ad