Closed Bug 1019334 Opened 5 years ago Closed 5 years ago
Array's (JSObject*) constructor overload
TypedArray's object-taking constructor is sort of broken. Remove it.
Comment on attachment 8432945 [details] [diff] [review] Patch Why not just have the one-arg ctor call Init() instead of making all the consumers do it?
Because then people have to check inited() themselves, manually, and remember to do it. Whereas if Init() is required to do anything, there's an existing call that must be made, and the burden of checking its return value is somewhat more obvious.
Comment on attachment 8432945 [details] [diff] [review] Patch OK, that's fair. I had mostly designed this constructor for those cases where you're MOZ_ASSERTing inited, but alright.
Attachment #8432945 - Flags: review?(bzbarsky) → review+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.