1019450 - Cleanup test_promiseBookmarksTree

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Asaf Romano (gone)]

Attachment: patch.diff

Minor cleanup.

Comment 1

[Marco Bonardo [:mak]]

Comment on attachment 8433174 [details] [diff] [review]
patch.diff

Review of attachment 8433174 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/tests/head_common.js
@@ +985,5 @@
> +    return "bookmarksMenuFolder";
> +  case PlacesUtils.toolbarFolderId:
> +    return "toolbarFolder";
> +  case PlacesUtils.unfiledBookmarksFolderId:
> +    return "unfiledBookmarksFolder";

please indent case(s) deeper than the switch

::: toolkit/components/places/tests/unit/test_promiseBookmarksTree.js
@@ +4,5 @@
>  
>  function* check_has_child(aParentGUID, aChildGUID) {
>    let parentTree = yield PlacesUtils.promiseBookmarksTree(aParentGUID);
> +  ok("children" in parentTree);
> +  notEqual(parentTree.children.find( e => e.guid == aChildGUID ), null);

my opinion is that we should retain the "Assert." part in Places as our style, to make test calls better distinguishable overall in the tests. what do you think?

Comment 2

[Marco Bonardo [:mak]]

I will just address my comments and land Mano's patch.

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1019450 - Cleanup test_promiseBookmarksTree.

Review commit: https://reviewboard.mozilla.org/r/138756/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138756/

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8867157 [details]
Bug 1019450 - Cleanup test_promiseBookmarksTree.

https://reviewboard.mozilla.org/r/138756/#review142044

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 8867157 [details]
Bug 1019450 - Cleanup test_promiseBookmarksTree.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/138756/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/318c40d7d0d8
Cleanup test_promiseBookmarksTree. r=mak

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/318c40d7d0d8