1019613 - First tap in the Marketplace page will open the same page in a new tab

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Catalin Suciu [:csuciu]]

Logging a separate bug for the issue reported in https://bugzilla.mozilla.org/show_bug.cgi?id=985867#c25.  

Steps:
1. Open marketplace.firefox.com via Menu > Tools > Apps
2. Tap anywhere on the page 

Results: marketplace.firefox.com is open in a new tab.

Note: This only happens at first tap on the page

Comment 1

[:Margaret Leibovic]

It looks like we need to add the same hack for about:apps that we landed for about:addons.

Are other pages affected, like about:downloads? I guess that doesn't have a link to a different webpage in the same way about:addons and about:apps do.

Comment 2

[Aaron Train [:aaronmt]]

We should probably address the core issue. What bug is that?

Comment 3

[:Margaret Leibovic]

(In reply to Aaron Train [:aaronmt] from comment #2)
> We should probably address the core issue. What bug is that?

An attempt for a real fix was made in bug 985867, but that got backed out. I think we should think about landing a similar hack for about:apps, then file a follow-up bug for a real fix, since I don't see a bug filed about that right now.

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Hack patch

Here's the same hack fix we used for addons. I'll file a separate bug to fix this correctly.

Comment 5

[Wesley Johnston (:wesj)]

Filed bug 1021148 for a real fix.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8435111 [details] [diff] [review]
Hack patch

> #ifndef MOZ_ANDROID_SYNTHAPKS
>   ContextMenus.init();
> #endif
>+
>+
>+  // XXX - Hack to fix bug 985867 for now
>+  document.addEventListener("touchstart", function() { });

One blank line is enough

Comment 7

[Wesley Johnston (:wesj)]

Landed an empty patch on accident:
https://hg.mozilla.org/integration/fx-team/rev/33eac5a39078
https://hg.mozilla.org/integration/fx-team/rev/ebbdf5f1a4a0

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/33eac5a39078
https://hg.mozilla.org/mozilla-central/rev/ebbdf5f1a4a0

Comment 9

[Catalin Suciu [:csuciu]]

Verified fixed on Nightly 33.0a1 (2014-06-18)