1019670 - Error in AboutHome.sendAboutHomeData: TypeError: target.messageManager is undefined" {file: "resource://app/modules/AboutHome.jsm" line: 248}

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

Attachment: Prototype fix

This warning seems to be ignored atm.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8433386 [details] [diff] [review]
Prototype fix

If target is non-null, why does it have a null messageManager?

Comment 2

[:Felipe Gomes (needinfo for replies!)]

So I believe the reason is that the element has been removed from the DOM tree. We still have a reference to it but after being removed it loses its frameLoader and the messageManager.

This is probably the same root cause for all the 3 bugs you've requested review. I think we need to first determine what is causing us to deal with items that are already removed from the DOM, before r+'ing these patches.

My first guess is tab closing...

Comment 3

[David Teller [:Yoric] - still alive but not very active]

I'll try and run the investigation. Any suggestion how to get started?

Comment 4

[:Felipe Gomes (needinfo for replies!)]

I guess finding the minimal testcase on how this happens.. You can them add some breakpoint; to the code and use the --jsdebugger option to start the test run with the debugger attached to try to find out where the trouble is

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/74fa63584506

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/74fa63584506