1019729 - Validation times out when uploading large packaged app

Status: VERIFIED FIXED

(Marketplace Graveyard :: Validation, defect, P1)

Description

[Tim Caswell]

Attachment: Archive.zip

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140506152807

Steps to reproduce:

I'm trying to submit a new app to the marketplace.

I created a FxOS app and tested locally using App Manager
I zipped the files and then uploaded to the web form.

Potentially related.  I can't seem to generate an APK to test locally on Android.  I get a 504 response from the https://controller-review.apk.firefox.com server.


Actual results:

The web form failed every time.
https://twitter.com/creationix/status/473861483814588416/photo/1



Expected results:

It should have accepted my upload and let me continue.

Comment 1

[Tim Caswell]

Attachment: Screenshot of failed upload

Comment 2

[Kumar McMillan [:kumar]]

Hi.

I was able to reproduce this using your package. It is causing our validator to time out, sorry about that. I'm not sure why. As a workaround, could you maybe remove anything from the package?

The exact server error (for tracking) is here: http://sentry.mktmon.services.phx1.mozilla.com/mkt/marketplacefirefoxcom/group/3948/

Comment 3

[Tim Caswell]

Sorry, I've already stripped it down to just 1.5mb.  I wouldn't consider that a large package.  I imagine most games are much larger with all their images and assets.

I could maybe get it down to half that size with some dead code removal and minification, (most my size is JS code) but that's substantial work and I can't do it today.

Comment 4

[Andrew Williamson [:eviljeff]]

its not really the total zip size (1.5mb isn't big at all).

Comment 5

[Tim Caswell]

Attachment: Updated screenshot of smaller file

Comment 6

[Tim Caswell]

Attachment: updated zip with smaller size

Comment 7

[Tim Caswell]

Just for fun, I removed some of the larger optional ace components and have a much smaller zip file.  It's still failing with the same error with only ~224kb of zip file.  I doubt this is a large file.

Comment 8

[Tim Caswell]

I filed my possibly related issue with the apk service at https://github.com/mozilla/apk-cli/issues/1.  Sorry if this is unrelated.

Comment 9

[Mark Striemer [:mstriemer]]

Running this locally it appears as though the validator is choking on some unicode in ace/ace.js. I output the JSON it got from spidermonkey and it ends referencing this area of ace.js.

> var _="→\n^K\f\r   <180e>             　\u2028\u2029<feff>"

Deleting the content from ace.js allows validation to proceed at which point it fails on a similar line in ace/worker-coffee.js (and a bunch of other files).

> var H="→   \n^K\f\r   <180e>             　\u2028\u2029<feff>"

Later it fails on src/pako/zlib/inflate.js with

>   File "/Users/mark/projects/app-validator/appvalidator/testcases/javascript/nodedefinitions.py", line 357, in <lambda>
>     ">>>=": lambda l, r, gl, gr: float(abs(int(gl)) >> gr),
> TypeError: unsupported operand type(s) for >>: 'int' and 'float'

Changing the erroring line to `">>>=": lambda l, r, gl, gr: float(abs(int(gl)) >> int(gr))` allows the small version to validate and that change along with removing the unicode files allows the full version to validate (more unicode work there I guess).

Comment 10

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/app-validator/commit/7b26e685b267f104e526c996ccb3891da8f29e12
https://github.com/mozilla/app-validator/commit/c3f328c6ebbe12947e564dfc23144762cf9e587f

Comment 11

[Iulian Timis]

Verified as fixed in https://marketplace-dev.allizom.org/developers/submit/ on FF33 (Win 7).
Postfix screencast http://screencast.com/t/l4qd6Dt9
Closing bug.