1019747 - New user story field in Tracking product is getting copied from Description, not User Story when cloning

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[David Bialer [:dbialer]]

Clone an existing bug.  Instead of the user story clone, the description field is being put into the user story field.

Based on Bug 967793 work.

Comment 1

[Gervase Markham [:gerv]]

Over to BMO.

Gerv

Comment 2

[David Lawrence [:dkl]]

Attachment: 1019747_1.patch

Comment 3

[:glob ✱]

Comment on attachment 8434390 [details] [diff] [review]
1019747_1.patch

Review of attachment 8434390 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

::: enter_bug.cgi
@@ +223,4 @@
>  $vars->{'qa_contact'}           = formvalue('qa_contact');
>  $vars->{'qa_contact_disabled'}  = !$has_editbugs;
>  
> +$vars->{'cloned_bug'}            = $cloned_bug;

this should be moved to within the if ($cloned_bug_id) block as it isn't required most of the time.

::: extensions/UserStory/template/en/default/hook/bug/create/create-after_custom_fields.html.tmpl
@@ +23,5 @@
> +        [% IF cloned_bug %]
> +          [% user_story_default = cloned_bug.cf_user_story %]
> +        [% ELSE %]
> +          [% user_story_default = "" %]
> +        [% END %]

nit: might be tidier as:
[% user_story_default = cloned_bug ? cloned_bug.cf_user_story : "" %]

Comment 4

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   b56bcda..db715a7  master -> master