1019885 - Saved password exceptions dialog shows "[object Object]"

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Justin Dolske [:Dolske]]

I'm assuming this may be a regression from bug 853549, so presumptively assigning :). If I go into Prefs -> Security -> Exceptions (for saved passwords) I get a dialog with a single line containing "[object Object]".

Looks like my logins.js data is correct, at the end is:

  "disabledHosts":[{"id":271,"hostname":"https://www.paypal.com"}]

(Although why is there an id in there? I though we nuked that.)

Comment 1

[Justin Dolske [:Dolske]]

Attachment: screenshot

No errors in the browser console, the debugging output seems normal:

Login Manager: Getting a list of all disabled hosts
PwMgr json: _getAllDisabledHosts: returning 1 disabled hosts.

Comment 2

[:Paolo Amadini]

(In reply to Justin Dolske [:Dolske] from comment #0)
> (Although why is there an id in there? I though we nuked that.)

You probably ran an early version of the patch and had an old-format database.

Confidently closing as INVALID, feel free to reopen if that happens again after nuking logins.json (and triggering the preference to reimport old passwords).

Comment 3

[(mostly gone) XtC4UaLL [:xtc4uall]]

(In reply to :Paolo Amadini from comment #2)
> (In reply to Justin Dolske [:Dolske] from comment #0)

> You probably ran an early version of the patch and had an old-format
> database.

I have the same problem and didn't try any earlier patches.
Removing logins.json presumably will be dataloss of new saved passwords between checkin of Bug 853549 & now?!

Comment 4

[:Gavin Sharp [email: [e-mail]]]

I see the same thing, and didn't test intermediate patches either.

Comment 5

[:Paolo Amadini]

It's a bad regression then! :-(

Will look into this as the first thing tomorrow.

Comment 6

[Justin Dolske [:Dolske]]

I also definitely didn't test intermediate patches.

Comment 7

[:Paolo Amadini]

Detailed steps to verify:

* Create a new profile using a version older than the Nightly channel.
* Go to a site that asks for a password.
* Enter the password, then choose "Never remember password for this site" from the drop-down.
* Open the same profile in Nightly (with this patch applied).
* Open the preferences, select "Security", then "Exceptions" near "Remember Passwords for Sites".
* The name of the site for which passwords were disabled should appear there.
* Go to the same site, enter a password and ensure that the browser does not ask to save it.

Marco, this bug should be added to the current iteration.

Comment 8

[Marco Mucci [:MarcoM]]

Added to Iteration 32.3

Comment 9

[:Paolo Amadini]

Attachment: The patch

The issue was in the migration code - unfortunately I didn't update the disabled hosts import code to the new format. Sorry if I dismissed this bug initially, I thought I tested that case but I probably didn't after the latest changes.

I also added code to fix the broken JSON file, I tested it using the STR above but executing the broken Nightly before the fixed one, and it seems to fix the format as expected.

Comment 10

[Justin Dolske [:Dolske]]

Comment on attachment 8434174 [details] [diff] [review]
The patch

Review of attachment 8434174 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/passwordmgr/LoginStore.jsm
@@ +269,5 @@
>  
> +    // Due to bug 1019885, invalid data was created by the import process in
> +    // Nightly.  This automated procedure fixes the error.  This is provided as
> +    // a convenience to Nightly users and can be safely removed after Nightly
> +    // users are updated to the new version.

Followup bug to actually remove this?

Technically this should probably be a version bump, but I suppose it's fair to treat it as a temporary fix for a Nightly bug.

Comment 11

[:Paolo Amadini]

https://hg.mozilla.org/integration/fx-team/rev/275b8b4d30ec

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/275b8b4d30ec

Comment 13

[Marco Mucci [:MarcoM]]

Hi Florin, can someone be assigned as the QA contact for verification of this bug.

Comment 14

[Andrei Vaida [:avaida]]

I was able to confirm the fix for this issue on Nightly 33.0a1 (2014-06-10), using:
 * Windows 7 64-bit [1],
 * Ubuntu 14.04 LTS 32-bit [2],
 * Mac OS X 10.9.2 [3],
with the instructions available in Comment 7.

[1] Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
[2] Mozilla/5.0 (X11; Linux i686; rv:33.0) Gecko/20100101 Firefox/33.0
[3] Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:33.0) Gecko/20100101 Firefox/33.0