1019893 - Link to TBPL in trychooser job result emails

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Nils Ohlmeier [:drno]]

It would be very helpful if the emails send out by TBPL for build warnings and failure would include the same link to the TBPL results overview page as the initial email after has in it.

Comment 1

[Ed Morley [:emorley]]

TBPL doesn't send out any emails - I presume these are the trychooser related emails, and so releng.

Could you provide an example email summary and body, so I can be clear which email you are referring to (and to aid finding where it is generated).

Comment 2

[Nils Ohlmeier [:drno]]

Didn't know this is part of trychooser, but yes I'm using that :-)

This is the initial email I get for submitting a Try build:

"
Thank you for your try submission. It's the best!

Results will be displayed on TBPL as they come in:
https://tbpl.mozilla.org/?tree=Try&rev=2292f29857a1
...
"

And a warning or failure email looks like this:

"
Your Try Server test (2292f29857a1) completed with warnings on builder try_ubuntu64_vm_test-mochitest-other.

Summary of test results:

The full log for this test run is available at...
"

It would be really helpful to get the tbpl.mozilla.org link in the warning/failure emails as well. Right now I have to keep the initial email to be able to click on the tbpl summary page and check out the problem reported by the second email.

Comment 3

[Ed Morley [:emorley]]

Attachment: Link to TBPL in trychooser job result emails

Adds a link to TBPL for all result emails, not just those that are missing the log_url (which is rare; only occurs when the upload failed).

Comment 4

[Ed Morley [:emorley]]

(Forgot to submit this comment earlier)

Ah great - that helps. Using:
http://mxr.mozilla.org/build-central/search?string=try%2Bsubmission

I get:
http://mxr.mozilla.org/build-central/source/buildbotcustom/status/generators.py#19
19 Thank you for your try submission. It's the best!
20 
21 Results will be displayed on TBPL as they come in:
22 https://tbpl.mozilla.org/?tree=%(tree)s&rev=%(revision)s

And:
http://mxr.mozilla.org/build-central/source/buildbotcustom/bin/try_mailer.py#127
125     if log_url:
126         log_url = log_url.replace('://stage', '://ftp')
127         text += "The full log for this %(task)s run is available at <a href=\"%(log_url)s\">%(log_url)s</a>.\n" % locals()
128     else:
129         text += "Please check <a href=\"https://tbpl.mozilla.org/?tree=%(tree)s&rev=%(revision)s\">Tinderbox Pushlog</a> for your logs.\n" % locals()

Comment 5

[Nils Ohlmeier [:drno]]

Comment on attachment 8434346 [details] [diff] [review]
Link to TBPL in trychooser job result emails

Review of attachment 8434346 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me :-)

Comment 6

[Ed Morley [:emorley]]

Thank you for the review :-)

How do changes to try_mailer.py get deployed?

remote:   https://hg.mozilla.org/build/buildbotcustom/rev/a1ea481a8c2c

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

That'll happen with the next merge to production and reconfig.

Comment 8

[Ed Morley [:emorley]]

(In reply to Nick Thomas [:nthomas] from comment #7)
> That'll happen with the next merge to production and reconfig.

Great - thank you :-)

Comment 9

[Chris Cooper [:coop] (he/him)]

Merged to production and deployed.

Comment 10

[Ed Morley [:emorley]]

This should be fixed now - let me know if the emails you get from now on are not what you expected :-)

Comment 11

[Nils Ohlmeier [:drno]]

Works like a charm. Thank you very much!