Closed Bug 1019911 Opened 10 years ago Closed 10 years ago

[Vertical Homescreen] Switch old homescreen only when it is required

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: jlorenzo, Assigned: viorela)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
viorela
: review+
Details | Review
The devs have modified gaia ui tests to switch back to the homescreen in the setUp.

However, switching the homescreen during the setUp is creating timing issues with other tests. To facilitate the migration, we need to:
* Move this to only change when we need it, so put the line into the setUp of tests that need the old homescreen
* Wait for the homescreen to have loaded
* Modify the atom to kill 'vertical' not 'homescreen'
Assignee: nobody → viorela.ioia
Summary: [Vertical Homescreen] Enable build flag in travis-ci → [Vertical Homescreen] Switch old homescreen only when it is required
Attached file github pr
First problem on device is that it is not waiting for the new homescreen to load.
Attachment #8434836 - Flags: review?(viorela.ioia)
Comment on attachment 8434836 [details] [review]
github pr

r+
Attachment #8434836 - Flags: review?(viorela.ioia) → review+
Don't need to do this now, we've landed all of the tests proper.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: