Open Bug 1020011 Opened 6 years ago Updated 2 years ago

Segment::justify leaks |stats|

Categories

(Core :: Graphics: Text, defect)

defect
Not set

Tracking

()

People

(Reporter: mccr8, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, memory-leak)

This function allocates an array |stats|, and then as far as Coverity and I can see, just returns without freeing it.
|stats| seems like a good candidate for stack allocation.
Ouch - yes, that looks like a bad leak. Fortunately, in Gecko we never call this at present. :) But cc'ing Martin so that upstream can fix it.
Thanks for spotting this. We will fix it. Is there any chance of getting the Graphite part of the coverity report so that we can address anything else it raises. We want Graphite to be as good code as we can make it. TIA.
(In reply to martin_hosken from comment #3)
> Thanks for spotting this. We will fix it. Is there any chance of getting the
> Graphite part of the coverity report so that we can address anything else it
> raises. We want Graphite to be as good code as we can make it. TIA.

Yeah, I can file bugs in bugzilla or email you about other things I see.  Offhand, I didn't notice a ton of things in Graphite code.
I'm removing the MemShrink tag because we're not shipping this code in Firefox.
Whiteboard: [MemShrink]
fixed upstream
You need to log in before you can comment on or make changes to this bug.