1020011 - Segment::justify leaks |stats|

Status: NEW

(Core :: Graphics: Text, defect)

Description

[Andrew McCreight (out of office until 8/21) [:mccr8]]

This function allocates an array |stats|, and then as far as Coverity and I can see, just returns without freeing it.

Comment 1

[Nicholas Nethercote [inactive]]

|stats| seems like a good candidate for stack allocation.

Comment 2

[Jonathan Kew [:jfkthame]]

Ouch - yes, that looks like a bad leak. Fortunately, in Gecko we never call this at present. :) But cc'ing Martin so that upstream can fix it.

Comment 3

[martin_hosken]

Thanks for spotting this. We will fix it. Is there any chance of getting the Graphite part of the coverity report so that we can address anything else it raises. We want Graphite to be as good code as we can make it. TIA.

Comment 4

[Andrew McCreight (out of office until 8/21) [:mccr8]]

(In reply to martin_hosken from comment #3)
> Thanks for spotting this. We will fix it. Is there any chance of getting the
> Graphite part of the coverity report so that we can address anything else it
> raises. We want Graphite to be as good code as we can make it. TIA.

Yeah, I can file bugs in bugzilla or email you about other things I see.  Offhand, I didn't notice a ton of things in Graphite code.

Comment 5

[Andrew McCreight (out of office until 8/21) [:mccr8]]

I'm removing the MemShrink tag because we're not shipping this code in Firefox.

Comment 6

[martin_hosken]

fixed upstream