1020110 - jit_test.py crashes if there are zero runnable tests in a directory

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Lars T Hansen [:lth]]

If no tests are run, for example if all tests are marked slow and slow tests are not run, then the test runner crashes with a domain error:

Process Process-2:
Traceback (most recent call last):
  File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
    self.run()
  File "/usr/lib/python2.7/multiprocessing/process.py", line 114, in run
    self._target(*self._args, **self._kwargs)
  File "/home/lth/moz/mozilla-central/js/src/tests/lib/jittests.py", line 540, in process_test_results_parallel
    ok = process_test_results(gen, num_tests, options)
  File "/home/lth/moz/mozilla-central/js/src/tests/lib/jittests.py", line 600, in process_test_results
    pb = ProgressBar(num_tests, fmt)
  File "/home/lth/moz/mozilla-central/js/src/tests/lib/progressbar.py", line 29, in __init__
    self.limit_digits = int(math.ceil(math.log10(self.limit))) # int: max digits in limit
ValueError: math domain error

Comment 1

[Lars T Hansen [:lth]]

Actually two bugs here, one is the domain error but once that is fixed the test harness hangs because there's a deadlock in the parallel test runner if there are zero tests.

Comment 2

[Lars T Hansen [:lth]]

Attachment: Fixes both bugs

The early-out in process_test_results avoids the domain error, and the dummy enqueue in run_tests_parallel avoids the deadlock.

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 8434023 [details] [diff] [review]
Fixes both bugs

Review of attachment 8434023 [details] [diff] [review]:
-----------------------------------------------------------------

Terrence is more familiar with jit-tests.

::: js/src/tests/lib/jittests.py
@@ +477,5 @@
>      try:
>          testcnt = 0
>          # Initially start as many jobs as allowed to run parallel
> +        # Always enqueue at least one to avoid a curious deadlock
> +        for i in range(max(1,min(options.max_jobs,total_tests))):

Nit: could you add a space after the two commas here? One of them is pre-existing :)

Comment 4

[Lars T Hansen [:lth]]

Attachment: Fixes both bugs, v2 with nit fixed

Comment 5

[Lars T Hansen [:lth]]

TBPL run (also see separate harness patch on bug 1019821):
https://tbpl.mozilla.org/?tree=Try&rev=728bbe3c2d95

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e106cac7c217

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e106cac7c217