1020139 - Support new KeyboardEvent.code value for Sun keyboard

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Now, code value spec defines special keys on Sun keyboard. We should support them.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The spec bug is this: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24739

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Mapping table of special keys on Sun keyboard

.code value     Label    Android (scancode / virtual keycode)   Linux (hardware keycode / keysym)

BrowserStop     Stop     0x80 / KEYCODE_MEDiA_STOP              0x88 / Cancel
Again           Again    0x81 / KEYCODE_UNKNOWN                 0x89 / Redo
ContextMenu     Props    0x82 / KEYCODE_UNKNOWN                 0x8A / SunProps
Undo            Undo     0x83 / KEYCODE_UNKNOWN                 0x8B / Undo
Select          Front    0x84 / KEYCODE_UNKNOWN                 0x8C / SunFront
Copy            Copy     0x85 / KEYCODE_UNKNOWN                 0x8D / XF86Copy
Open            Open     0x86 / KEYCODE_UNKNOWN                 0x8E / XF86Open
Paste           Paste    0x87 / KEYCODE_UNKNOWN                 0x8F / XF86Paste
Find            Find     0x88 / KEYCODE_UNKNOWN                 0x90 / Find
Cut             Cut      0x89 / KEYCODE_UNKNOWN                 0x91 / XF86Cut

# Stop key is probably same as BrowserStop key physically. Both on Android and Linux, the sancode values are same as BrowserStop key.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Now, "Props" should be "Props". (Discussed today's meeting)
https://www.w3.org/Bugs/Public/show_bug.cgi?id=24739#c10

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.1 Sort out legacy keys section of code value for the latest spec and add code values for Sun keyboard

First, define legacy key code values defined in:
https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3Events-code.html#key-legacy

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.2 Map special keys on Sun keyboard on Linux

See comment 2 and comment 3.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.3 Map special keys on Sun keyboard on Android and Gonk

See comment 2 and comment 3. I confirmed this only with Android (Nexus 7, 2013)

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I.e., the patches making following mapping:

Mapping table of special keys on Sun keyboard

.code value     Label    Android (scancode / virtual keycode)   Linux (hardware keycode / keysym)

Again           Again    0x81 / KEYCODE_UNKNOWN                 0x89 / Redo
Props           Props    0x82 / KEYCODE_UNKNOWN                 0x8A / SunProps
Undo            Undo     0x83 / KEYCODE_UNKNOWN                 0x8B / Undo
Select          Front    0x84 / KEYCODE_UNKNOWN                 0x8C / SunFront
Copy            Copy     0x85 / KEYCODE_UNKNOWN                 0x8D / XF86Copy
Open            Open     0x86 / KEYCODE_UNKNOWN                 0x8E / XF86Open
Paste           Paste    0x87 / KEYCODE_UNKNOWN                 0x8F / XF86Paste
Find            Find     0x88 / KEYCODE_UNKNOWN                 0x90 / Find
Cut             Cut      0x89 / KEYCODE_UNKNOWN                 0x91 / XF86Cut

Comment 8

[Chris Peterson [:cpeterson]]

Comment on attachment 8555846 [details] [diff] [review]
part.3 Map special keys on Sun keyboard on Android and Gonk

Review of attachment 8555846 [details] [diff] [review]:
-----------------------------------------------------------------

Android changes LGTM, but I have not verified the scancode values. I don't have a Sun keyboard. :)

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0870b9735cea
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0cbb45a4ee7
https://hg.mozilla.org/integration/mozilla-inbound/rev/67f185a86c4b

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0870b9735cea
https://hg.mozilla.org/mozilla-central/rev/b0cbb45a4ee7
https://hg.mozilla.org/mozilla-central/rev/67f185a86c4b

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://developer.mozilla.org/en-US/Firefox/Releases/38
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent.code