Support new KeyboardEvent.code value for Sun keyboard

RESOLVED FIXED in mozilla38

Status

()

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

({dev-doc-complete})

Trunk
mozilla38
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Now, code value spec defines special keys on Sun keyboard. We should support them.
Mapping table of special keys on Sun keyboard

.code value     Label    Android (scancode / virtual keycode)   Linux (hardware keycode / keysym)

BrowserStop     Stop     0x80 / KEYCODE_MEDiA_STOP              0x88 / Cancel
Again           Again    0x81 / KEYCODE_UNKNOWN                 0x89 / Redo
ContextMenu     Props    0x82 / KEYCODE_UNKNOWN                 0x8A / SunProps
Undo            Undo     0x83 / KEYCODE_UNKNOWN                 0x8B / Undo
Select          Front    0x84 / KEYCODE_UNKNOWN                 0x8C / SunFront
Copy            Copy     0x85 / KEYCODE_UNKNOWN                 0x8D / XF86Copy
Open            Open     0x86 / KEYCODE_UNKNOWN                 0x8E / XF86Open
Paste           Paste    0x87 / KEYCODE_UNKNOWN                 0x8F / XF86Paste
Find            Find     0x88 / KEYCODE_UNKNOWN                 0x90 / Find
Cut             Cut      0x89 / KEYCODE_UNKNOWN                 0x91 / XF86Cut

# Stop key is probably same as BrowserStop key physically. Both on Android and Linux, the sancode values are same as BrowserStop key.
See comment 2 and comment 3. I confirmed this only with Android (Nexus 7, 2013)
Attachment #8555846 - Flags: review?(cpeterson)
I.e., the patches making following mapping:

Mapping table of special keys on Sun keyboard

.code value     Label    Android (scancode / virtual keycode)   Linux (hardware keycode / keysym)

Again           Again    0x81 / KEYCODE_UNKNOWN                 0x89 / Redo
Props           Props    0x82 / KEYCODE_UNKNOWN                 0x8A / SunProps
Undo            Undo     0x83 / KEYCODE_UNKNOWN                 0x8B / Undo
Select          Front    0x84 / KEYCODE_UNKNOWN                 0x8C / SunFront
Copy            Copy     0x85 / KEYCODE_UNKNOWN                 0x8D / XF86Copy
Open            Open     0x86 / KEYCODE_UNKNOWN                 0x8E / XF86Open
Paste           Paste    0x87 / KEYCODE_UNKNOWN                 0x8F / XF86Paste
Find            Find     0x88 / KEYCODE_UNKNOWN                 0x90 / Find
Cut             Cut      0x89 / KEYCODE_UNKNOWN                 0x91 / XF86Cut
Attachment #8555844 - Flags: review?(bugs) → review+
Comment on attachment 8555846 [details] [diff] [review]
part.3 Map special keys on Sun keyboard on Android and Gonk

Review of attachment 8555846 [details] [diff] [review]:
-----------------------------------------------------------------

Android changes LGTM, but I have not verified the scancode values. I don't have a Sun keyboard. :)
Attachment #8555846 - Flags: review?(cpeterson) → review+
Attachment #8555845 - Flags: review?(karlt) → review+
You need to log in before you can comment on or make changes to this bug.