1020164 - Telemetry for AudioStream open time

Status: RESOLVED DUPLICATE of bug 1006641

(Core :: Audio/Video, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

Measure the time it takes to open an AudioStream in the field, for the first (slow) open and subsequent (faster) opens.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: add telemetry for AudioStream open times

I could have sworn there was a separate bug on this....  Oh well.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8433981 [details] [diff] [review]
add telemetry for AudioStream open times

Review of attachment 8433981 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/AudioStream.cpp
@@ +511,5 @@
> +		TimeDuration timeDelta = TimeStamp::Now() - mStartTime;
> +		Telemetry::Accumulate(mIsFirst ? Telemetry::AUDIOSTREAM_FIRST_OPEN :
> +                          Telemetry::AUDIOSTREAM_LATER_OPEN, timeDelta.ToMilliseconds());
> +  }
> +		 

I'll remove the spaces

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8433981 [details] [diff] [review]
add telemetry for AudioStream open times

Review of attachment 8433981 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/AudioStream.cpp
@@ +394,5 @@
>                    const dom::AudioChannel aAudioChannel,
>                    LatencyRequest aLatencyRequest)
>  {
> +  mStartTime = TimeStamp::Now();
> +  mIsFirst = GetFirstStream();

It might be negligible, but you can exchange the 2 lines so that GetFirstStream() is not included in the init time.