Update IONFLAGS error message to suggest --ion-parallel-compile=off

RESOLVED INVALID

Status

()

RESOLVED INVALID
4 years ago
2 years ago

People

(Reporter: nbp, Assigned: amol.com, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][lang=c++])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
(In reply to Amol Mundayoor from Bug 1012632 comment #27)
> In Comment #7, Nicolas mentioned that I could fix up an error message if I
> felt like it. I do feel like it, and found that the message is located at
> Ion.cpp:1914. Are there any preferences on what this should change to? I was
> simply thinking of appending "Re-run with flag --ion-parallel-compile=off"
> or something similar to the error string.

This sounds like a good plan. :)
(Assignee)

Comment 1

4 years ago
Created attachment 8436278 [details] [diff] [review]
b1020184.patch

Here you go :)
Attachment #8436278 - Flags: review?(nicolas.b.pierron)
(Reporter)

Comment 2

4 years ago
Comment on attachment 8436278 [details] [diff] [review]
b1020184.patch

Review of attachment 8436278 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/Ion.cpp
@@ +1915,1 @@
>                                builderScript->filename(), builderScript->lineno());

style-nit: Avoid going above 100 characters per line.

   "%s:%d: Cannot log compilation due to background compilation.\n"
   "Re-run with the flag --ion-parallel-compile=off to disable the background compilation."
Attachment #8436278 - Flags: review?(nicolas.b.pierron) → feedback+
(Reporter)

Comment 3

4 years ago
You might also want to take into consideration the work which is being done in Bug 1020364. ;)
Mentor: nicolas.b.pierron
Whiteboard: [good first bug][mentor=nbp][lang=c++] → [good first bug][lang=c++]

Comment 4

4 years ago
What's the current status of this bug?

Comment 5

4 years ago
Hi! I'm interested to fix one bug, but I'm new no bugzilla. I want to work in this bug and try to fix it until 30th october. Could someone mentor me?
(Reporter)

Comment 6

4 years ago
Amol, can you fix the nit that I suggested in comment 2?

Himanshu, Yussif, If you are interested in fixing issues you can have a look at the documentation of SpiderMonkey, and how to build the JavaScript shell[1] then pick a bug on Bugs Ahoy[2].

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey
[2] http://www.joshmatthews.net/bugsahoy/?jseng=1
Flags: needinfo?(amol.com)

Comment 7

2 years ago
Is this bug still exists?
Flags: needinfo?(nicolas.b.pierron)
(Reporter)

Comment 8

2 years ago
(In reply to Jinank Jain from comment #7)
> Is this bug still exists?

This bug is now invalid, as Bug 1147403 part 3 added support for off-thread logging with IONFLAGS.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Flags: needinfo?(nicolas.b.pierron)
Resolution: --- → INVALID
(Reporter)

Updated

2 years ago
Flags: needinfo?(amol.com)
You need to log in before you can comment on or make changes to this bug.