1020257 - Dispatch hud events on the main window for system app related events

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This patch is one of the piece needed to have the hud working for the system app.

It relies on the patch in bug 1015894 that I'm going to land this week.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: devtools.dispatch.events.onmainwindow.for.system.patch

Comment 2

[Jan Keromnes [:janx]]

Comment on attachment 8434074 [details] [diff] [review]
devtools.dispatch.events.onmainwindow.for.system.patch

Review of attachment 8434074 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense, thank you Vivien.

::: b2g/chrome/content/devtools.js
@@ +271,5 @@
>      this._send({});
>    },
>  
>    _send: function target_send(data) {
> +    let target = this.frame;

Nit: Since this is a prototype method of Target, the naming might be confusing here. Please s/target/frame/ or similar.

@@ +273,5 @@
>  
>    _send: function target_send(data) {
> +    let target = this.frame;
> +
> +    let systemapp = document.querySelector('#systemapp');

Nit: Please use `document.getElementById`.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dbcb9974b640

Comment 4

[Ryan VanderMeulen [:RyanVM]]

This push hit desktop B2G mochitest failures. Not knowing the interdependencies of the push, I backed the entire thing out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/616163ca1aa5

https://tbpl.mozilla.org/php/getParsedLog.php?id=41052634&tree=Mozilla-Inbound

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e0da2d69cfdb

Comment 6

[Julien Wajsberg [:julienw]]

I think this produced issues in the Marionette JS tests (Gi in TBPL):
https://tbpl.mozilla.org/php/getParsedLog.php?id=41112344&tree=Mozilla-Inbound#error4

Here is a try with this issue backed out:
https://tbpl.mozilla.org/?tree=Try&rev=0fb26a81b986

Comment 7

[Julien Wajsberg [:julienw]]

This line is the likely failure:

    shell.sendEvent(frame, 'developer-hud-update', Cu.cloneInto(data, target));

"target" is not defined anywhere here...

Comment 8

[Julien Wajsberg [:julienw]]

Can we please backout this? I'm pretty sure this patch is the issue and so don't want to wait for try.

Then can you respin a build on moz-central ?

Comment 9

[Julien Wajsberg [:julienw]]

Try with Gi is: https://tbpl.mozilla.org/?tree=Try&rev=0fb26a81b986&showall=1

Comment 10

[Carsten Book [:Tomcat]]

backed this out from mozilla-central (and so also in the upcoming merges from the other integration trees) in https://hg.mozilla.org/mozilla-central/rev/c8288d0c7a15 as requested in comment #8 and on irc

Comment 11

[Jan Keromnes [:janx]]

> shell.sendEvent(frame, 'developer-hud-update', Cu.cloneInto(data, target));
>                                                                   ^

Vivien, I think you forgot to rename the last occurrence of "target" to "frame" in the patch you landed.

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Jan Keromnes [:janx] from comment #11)
> > shell.sendEvent(frame, 'developer-hud-update', Cu.cloneInto(data, target));
> >                                                                   ^
> 
> Vivien, I think you forgot to rename the last occurrence of "target" to
> "frame" in the patch you landed.

Sigh...

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/165b068b01c2