102032 - Fix tinderbox test errors and warnings

Status: RESOLVED FIXED

(Bugzilla :: Testing Suite, defect, P3)

Description

[Zach Lipton [:zach]]

We need to fix the test errors and warnings so that testing can be enabled 
by default. Patch to fix some of these errors is coming.

Comment 1

[Zach Lipton [:zach]]

Attachment: Patch to fix many of these errors and warnings

Comment 2

[Zach Lipton [:zach]]

The patch that I just attached should fix a lot of these:

before:

Failed Test     Stat Wstat Total Fail  Failed  List of Failed
-------------------------------------------------------------------------------
t/001compile.t     1   256    54    1   1.85%  28
t/002goodperl.t    4  1024   100    4   4.00%  31 36 55 81
Failed 2/3 test scripts, 33.33% okay. 5/204 subtests failed, 97.55% okay.

after: 
Failed Test     Stat Wstat Total Fail  Failed  List of Failed
-------------------------------------------------------------------------------
t/001compile.t     1   256    54    1   1.85%  28
t/002goodperl.t    1   256   100    1   1.00%  81
Failed 2/3 test scripts, 33.33% okay. 2/204 subtests failed, 99.02% okay.

so we go from 97.55% to 99.02%, thats a big improvement! Only two 
more tests left!

Comment 3

[Dave Miller [:justdave]]

Comment on attachment 51119 [details] [diff] [review]
Patch to fix many of these errors and warnings

Try uploading the patch again with MacBinary turned off. :)

Comment 4

[Zach Lipton [:zach]]

Attachment: with unix linebreaks

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 51128 [details] [diff] [review]
with unix linebreaks

You still have a MacBinary header on it.  And you trapped standard error in it this time, too...

Comment 6

[Dave Miller [:justdave]]

first patch looks good if you get the MacBinary off.

r= justdave, no 2nd required

Comment 7

[Zach Lipton [:zach]]

Patch at /var/www/errors.patch (on landfill) checked in. Keeping this open 
to deal with the other issues.

Comment 8

[Jacob Steenhagen]

Attachment: Fix new_comment.cgi

Comment 9

[Jacob Steenhagen]

Attachment 51210 [details] [diff] makes new_comment.cgi pass the goodperl.t check.  Bug 54703
exists for further improvements needed to this file, but is (obviously) beyond
the scope of this bug.

With this patch and attachment 49752 [details] [diff] [review] from bug 98095:
t/001compile........ok                                                       
t/002goodperl.......ok                                                       
t/003safesys........ok                                                       
All tests successful.
Files=3, Tests=204, 28 wallclock secs (24.03 cusr +  1.77 csys = 25.80 CPU)

Comment 10

[Dave Miller [:justdave]]

Comment on attachment 51210 [details] [diff] [review]
Fix new_comment.cgi

r= justdave
no 2nd review needed

Comment 11

[Jacob Steenhagen]

This has been checked in.

Comment 12

[Matthew Tuck [:CodeMachine]]

test

Comment 13

[Matthew Tuck [:CodeMachine]]

test2