1020401 - enforce test timeouts for CI savings

Status: RESOLVED DUPLICATE of bug 1020458

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Tomislav Jovanovic :zombie]

investigating bug 1020384, i asked: 

i thought we (jetpack) controlled that 7200s timeout, not releng..

philor responded:

> that's the thing I would really like to have fixed, the way jetpack *doesn't*
> control it, it just hangs and waits for buildbot to kill it, but I presume 
> there's some reason there's no internal handling of hangs, like "the thing 
> that would watch for them is also hung"


it looks like we set `enforce_timeouts` only for the `test` command [1], and not for other "test" commands (testpkgs, testaddons).  seems like we should be able to fix that without too much problems?

Wes, do you have any input on this, and/or know who would, apart from Dave?


[1] https://github.com/mozilla/addon-sdk/blob/master/python-lib/cuddlefish/__init__.py#L663

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I don't really know much about the test infra stuff, but yeah, it looks like it'd be fairly easy to enforce timeouts by adding that line elsewhere.

Comment 2

[Tomislav Jovanovic :zombie]

i was asking more if you know a reason why we didn't/shouldn't do this, or maybe warn me about some dragons.. ;)

but given Ed's bugs, and your irc comments, i'm gonna try this!

Comment 3

[Ed Morley [:emorley]]

Thank you for looking at this :-)

Comment 4

[Tomislav Jovanovic :zombie]

i fail at code comprehension, we actually did enforce timeouts for all testxxx commands, except for testaddons. 

Erik was faster to fix this in bug 1020458, so i'm just gonna close this one as dup.