Closed Bug 1020435 Opened 11 years ago Closed 11 years ago

Finalize FTE tutorial strings

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::First Time Experience
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.0)

Status:
RESOLVED FIXED
Milestone:
2.0 S3 (6june)
Project Flags:
feature-b2g 2.0

People

(Reporter: sfoster, Assigned: sfoster)

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

PR: One word fix to finalize tutorial strings
46 bytes, text/x-github-pull-request
fcampo
: review+
flod
: feedback+
Details | Review
The text accompanying each of the 3 video steps needs to be finalized
Candice: we need this for 2.0, the videos themselves can get updated later (bug 1019289) but the strings should be locked by 06/09
Flags: needinfo?(jsavory)
Flags: needinfo?(cserran)
(In reply to Sam Foster [:sfoster] from comment #1) > Candice: we need this for 2.0, the videos themselves can get updated later > (bug 1019289) but the strings should be locked by 06/09 I updated the feature flag and added our tags. Thanks Sam! Will you be assigning this to yourself?
feature-b2g: --- → 2.0
Flags: needinfo?(cserran)
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S3 (6june)
Flags: needinfo?(sfoster)
I'll take it for now, but anyone should feel free to steal from me. Its mostly a matter of updating the relavent string properties in apps/ftu/locales/ftu.en-US.properties, butthat there is at least one test that checks the string value that should be double-checked. Jacqueline, do you think you can get these finalized by or before Friday 06/06?
Assignee: nobody → sfoster
Flags: needinfo?(sfoster)
Specifically we currently have: tutorial-vertical-scroll-tiny = Swipe up and down to browse your apps. Tap and hold on an icon to move or delete it. tutorial-notifications-tiny = Swipe down to access recent notifications, credit information and settings. tutorial-sheets-tiny = Drag from the left edge of your screen to return to recently used apps. If that's ok, then we are done here.
Aside from the detail on the vertical scroll that you noticed Sam: "Tap and hold an icon" rather than "Tap and hold on an icon" I think that these strings will work as the final version.
Flags: needinfo?(jsavory)
Rubber-stamp please?
Attachment #8435392 - Flags: review?(fernando.campo)
Comment on attachment 8435392 [details] [review] PR: One word fix to finalize tutorial strings codewise, everything's good, but I guess that changes on strings should get l10n-approval
Attachment #8435392 - Flags: review?(fernando.campo) → review+
Comment on attachment 8435392 [details] [review] PR: One word fix to finalize tutorial strings This kind of minor change is OK, always safer to ask. Note that ideally we should add strings only after they've been copy reviewed, that would save time for everyone ;-)
Attachment #8435392 - Flags: feedback+
Right, the changes here weren't actually mistakes as such - I was using wording from existing strings. But there was a question raised about them so I opened this bug to make sure we reviewed them in-context before branching. Is there a flag I can use to indicate a bug involves string changes in the future?
Flags: needinfo?(francesco.lodolo)
Unfortunately no, once landed on master, we need new IDs. More info here https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Changing_existing_strings
Flags: needinfo?(francesco.lodolo)
Ok, I can leave the existing ones alone. They are only used by the tablet now and will go away entirely in 2.1
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: