1020439 - GetCairoSurfaceForSourceSurface fails to free surf on failure

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Andrew McCreight [:mccr8]]

cairo_surface_status derefs surf, so it seems like surf must be allocated.

I think this is a regression from bug 803568.  Given that that was a sec bug, I assume this isn't a common thing to have happen.

Looking at the patch there, I'm guessing this also affects DrawTargetCairo::CreateSourceSurfaceFromData().
  https://hg.mozilla.org/mozilla-central/rev/152d3caaf16a

Comment 1

[Andrew McCreight [:mccr8]]

DrawTargetCairo::CreateShadowDrawTarget() seems to do the same thing, with |tee|.

Comment 2

[Sodan [:sodan]]

Attachment: call cairo_surface_destroy in case of failure

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 8444113 [details] [diff] [review]
call cairo_surface_destroy in case of failure

Review of attachment 8444113 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me, but I'm going to forward the review to a graphics peer.

Comment 4

[Andrew McCreight [:mccr8]]

try run: https://tbpl.mozilla.org/?tree=Try&rev=cf9cf18c8f8a

Comment 5

[Andrew McCreight [:mccr8]]

Thanks for the patch!

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b483618e693

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2b483618e693