Closed Bug 1020439 Opened 6 years ago Closed 6 years ago

GetCairoSurfaceForSourceSurface fails to free surf on failure

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: mccr8, Assigned: sodan, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, memory-leak, Whiteboard: [MemShrink:P3] )

Attachments

(1 file)

cairo_surface_status derefs surf, so it seems like surf must be allocated.

I think this is a regression from bug 803568.  Given that that was a sec bug, I assume this isn't a common thing to have happen.

Looking at the patch there, I'm guessing this also affects DrawTargetCairo::CreateSourceSurfaceFromData().
  https://hg.mozilla.org/mozilla-central/rev/152d3caaf16a
DrawTargetCairo::CreateShadowDrawTarget() seems to do the same thing, with |tee|.
Whiteboard: [MemShrink] → [MemShrink] [mentor=mccr8]
Whiteboard: [MemShrink] [mentor=mccr8] → [MemShrink:P3] [mentor=mccr8]
Mentor: continuation
Whiteboard: [MemShrink:P3] [mentor=mccr8] → [MemShrink:P3]
Assignee: nobody → neocorp64
Attachment #8444113 - Flags: review?(continuation)
Comment on attachment 8444113 [details] [diff] [review]
call cairo_surface_destroy in case of failure

Review of attachment 8444113 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me, but I'm going to forward the review to a graphics peer.
Attachment #8444113 - Flags: review?(continuation) → review?(bas)
Attachment #8444113 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/2b483618e693
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.