1020471 - WebrtcClient is not defined

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

I'm getting the following error:

JavaScript Error: "ReferenceError: WebrtcClient is not defined" {file: "app://communications.gaiamobile.org/contacts/js/views/details.js" line: 107}

when doing an import in contacts.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Hi Borja,

It looks like we are missing to import the webrtclient.js from a different path, I guess we have an unkonwn path when comming from activities.

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Since loop is a 2.0 feature nominating this for 2.0.

Thanks!

Comment 3

[Wilfred Mathanaraj [:WDM]]

if this is needed for loop then i suppose it should be.

Comment 4

[Jason Smith [:jsmith]]

What's the user impact to Loop here?

Comment 5

[Maria Angeles Oteo (:oteo)]

As Francisco has told me, without fixing this, we will not be able to make WebRTC/Loop calls from the contacts application, so we need to block on it

Comment 6

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: per comment 3 and comment 5

Comment 7

[Borja Salguero [:borjasalguero]]

Taking a look right now.

Comment 8

[Borja Salguero [:borjasalguero]]

Sergi, Could you describe the STR? I can not reproduce it with today's build.

Take into account that you need to try Gaia master with an up-to-date Gecko, due to WebrtcClient depends on a Gecko patch which was recently landed.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

I could not reproduce in todays build, but I'm sending a patch for preventing any kind of error like that and also adding unit tests.

The lack of unit tests for handling the details back didn't help, now we test it.

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to pr 20301

As mentioned before this patch is to prevent (as I cannot see it) calling a function over a null object.

Most of the patch is unit tests to check this.

Comment 11

[Jose Manuel Cantera]

Comment on attachment 8437718 [details] [review]
Pointer to pr 20301

thanks Francisco

Comment 12

[Borja Salguero [:borjasalguero]]

Comment on attachment 8437718 [details] [review]
Pointer to pr 20301

As I told before I was not able to reproduce the error, but more we can shield our code against failures, the best. Thanks!

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/arcturus/gaia/commit/e72641ba1116c38336e348ef5e1813f08e7ab261

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/981a1179d5bcd5397f1ddbbbe13522629e61e0d2

Comment 15

[Lancy(Leave from Mozilla)]

Attachment: logcat_Flame2.0.txt

This issue has been verified successfully on Flame 2.0 & 2.1, There is no the error message of "JavaScript Error: "ReferenceError: WebrtcClient is not defined"" shown in the log.

See attachment: logcat_Flame2.0.txt & logcat_Flame2.1.txt
Reproducing rate: 0/10

Flame v2.0 version:
Gaia-Rev        856863962362030174bae4e03d59c3ebbc182473
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/e40fe21e37f1
Build-ID        20141208000206
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141208.035628
FW-Date         Mon Dec  8 03:56:38 EST 2014
Bootloader      L1TC00011880

Flame v2.1 version:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141205.035305
FW-Date         Fri Dec  5 03:53:16 EST 2014
Bootloader      L1TC00011880

Comment 16

[Lancy(Leave from Mozilla)]

Attachment: logcat_Flame2.1.txt