1020540 - Include only those components we need from SJCL

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Adam Roach [:abr]]

Currently, we're including the whole SJCL library, even though we use it only for its HMAC-SHA256 function. We should really only include those rings we need; this can be achived using the following config string with the SJCL build system:

> ./configure --without-all --with-hmac --with-codecHex && make

Comment 1

[Adam Roach [:abr]]

Attachment: Include only those components we need from SJCL

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8434384 [details] [diff] [review]
Include only those components we need from SJCL

Ok, I've verified the code still seems to work with this change, so r=Standard8.

Comment 3

[Adam Roach [:abr]]

https://hg.mozilla.org/projects/elm/rev/fa0b0d413edb

Comment 4

[Mark Banner (:standard8)]

https://hg.mozilla.org/mozilla-central/rev/fa0b0d413edb

Comment 5

[u279076]

This does not appear to be something that needs QA before we release. Please needinfo me to request specific testing.