Closed Bug 1020540 Opened 10 years ago Closed 10 years ago

Include only those components we need from SJCL

Categories

(Hello (Loop) :: Client, defect)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla33

People

(Reporter: abr, Assigned: abr)

Details

Attachments

(1 file)

Include only those components we need from SJCL
26.93 KB, patch
standard8
: review+
Details | Diff | Splinter Review 
Currently, we're including the whole SJCL library, even though we use it only for its HMAC-SHA256 function. We should really only include those rings we need; this can be achived using the following config string with the SJCL build system:

> ./configure --without-all --with-hmac --with-codecHex && make

        Attachment #8434384 -
        Flags: review?(standard8)

    
    

    
  
Comment on attachment 8434384 [details] [diff] [review]
Include only those components we need from SJCL

Ok, I've verified the code still seems to work with this change, so r=Standard8.

        Attachment #8434384 -
        Flags: review?(standard8) → review+

    
  
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Target Milestone: mozilla32 → mozilla33

    
    

    
  
This does not appear to be something that needs QA before we release. Please needinfo me to request specific testing.
Whiteboard: [qa-]

    
  
Flags: qe-verify-
Whiteboard: [qa-]

          You need to log in
          before you can comment on or make changes to this bug.