Closed
Bug 1020540
Opened 11 years ago
Closed 11 years ago
Include only those components we need from SJCL
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla33
People
(Reporter: abr, Assigned: abr)
Details
Attachments
(1 file)
|
26.93 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
Currently, we're including the whole SJCL library, even though we use it only for its HMAC-SHA256 function. We should really only include those rings we need; this can be achived using the following config string with the SJCL build system:
> ./configure --without-all --with-hmac --with-codecHex && make
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8434384 -
Flags: review?(standard8)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8434384 [details] [diff] [review]
Include only those components we need from SJCL
Ok, I've verified the code still seems to work with this change, so r=Standard8.
Attachment #8434384 -
Flags: review?(standard8) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Updated•11 years ago
|
Target Milestone: --- → mozilla32
|
|
||
Comment 4•11 years ago
|
||
|
|
||
Updated•11 years ago
|
Target Milestone: mozilla32 → mozilla33
This does not appear to be something that needs QA before we release. Please needinfo me to request specific testing.
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•