Include only those components we need from SJCL

RESOLVED FIXED in mozilla33

Status

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: abr, Assigned: abr)

Tracking

unspecified
mozilla33
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Currently, we're including the whole SJCL library, even though we use it only for its HMAC-SHA256 function. We should really only include those rings we need; this can be achived using the following config string with the SJCL build system:

> ./configure --without-all --with-hmac --with-codecHex && make
(Assignee)

Comment 1

5 years ago
Created attachment 8434384 [details] [diff] [review]
Include only those components we need from SJCL
Attachment #8434384 - Flags: review?(standard8)
Comment on attachment 8434384 [details] [diff] [review]
Include only those components we need from SJCL

Ok, I've verified the code still seems to work with this change, so r=Standard8.
Attachment #8434384 - Flags: review?(standard8) → review+
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Target Milestone: mozilla32 → mozilla33
This does not appear to be something that needs QA before we release. Please needinfo me to request specific testing.
Whiteboard: [qa-]
Flags: qe-verify-
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.