Closed Bug 1020549 Opened 10 years ago Closed 10 years ago

[NFC] Invalid use of "let" in NDEFUtils

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kamituel, Assigned: kamituel)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
gweng
: review+
Details | Review
I used "let" keyword in NDEFUtils recently, which causes error:

> E/GeckoConsole(20506): [JavaScript Error: "SyntaxError: let is a reserved 
> identifier" {file: "app://system.gaiamobile.org/js/ndef_utils.js"
> line: 246 column: 6
> source: "      let m = mac[i].toString(16);

I have no idea why no unit test failed, nor why Travis passed.

I'm marking it as blocking 2.0, because it causes NDEFUtils not to load at all.
blocking-b2g: --- → 2.0?
Attached file Pull request
Attachment #8434731 - Flags: review?(gweng)
Comment on attachment 8434731 [details] [review]
Pull request

So be it. But I think this is a weird bug (try from app-manager it's OK to use 'let' in the console).
Attachment #8434731 - Flags: review?(gweng) → review+
Yes, it is a strange bug. Maybe it's broken on Flame only? (this is where I discovered it)
Keywords: checkin-needed
master: https://github.com/mozilla-b2g/gaia/commit/ac47da8f463aabcbf7d93aa76e3d517753d02302
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
blocking-b2g: 2.0? → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: