Closed
Bug 1020549
Opened 11 years ago
Closed 11 years ago
[NFC] Invalid use of "let" in NDEFUtils
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kamituel, Assigned: kamituel)
References
Details
Attachments
(1 file)
I used "let" keyword in NDEFUtils recently, which causes error:
> E/GeckoConsole(20506): [JavaScript Error: "SyntaxError: let is a reserved
> identifier" {file: "app://system.gaiamobile.org/js/ndef_utils.js"
> line: 246 column: 6
> source: " let m = mac[i].toString(16);
I have no idea why no unit test failed, nor why Travis passed.
I'm marking it as blocking 2.0, because it causes NDEFUtils not to load at all.
|
Assignee | |
Updated•11 years ago
|
blocking-b2g: --- → 2.0?
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8434731 -
Flags: review?(gweng)
|
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8434731 [details] [review]
Pull request
So be it. But I think this is a weird bug (try from app-manager it's OK to use 'let' in the console).
Attachment #8434731 -
Flags: review?(gweng) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Yes, it is a strange bug. Maybe it's broken on Flame only? (this is where I discovered it)
Keywords: checkin-needed
|
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Updated•11 years ago
|
blocking-b2g: 2.0? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•