DrawTargetSkia::CopySurface is broken with A8 surfaces

RESOLVED FIXED in mozilla33

Status

()

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
mozilla33
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Created attachment 8434478 [details] [diff] [review]
DrawTargetSkia::CopySurface is broken with A8 surfaces

This fixes this for some of the cases. It should also make CopySurface faster some of the time.

Skia could really use a better api for this...
(Assignee)

Comment 1

4 years ago
Created attachment 8435828 [details] [diff] [review]
DrawTargetSkia::CopySurface is broken with A8 surfaces
Attachment #8434478 - Attachment is obsolete: true
Attachment #8435828 - Flags: review?(gwright)
Comment on attachment 8435828 [details] [diff] [review]
DrawTargetSkia::CopySurface is broken with A8 surfaces

Review of attachment 8435828 [details] [diff] [review]:
-----------------------------------------------------------------

Would prefer a #ifdef rather than if(false) with a semi-descriptive define, but looks fine.
Attachment #8435828 - Flags: review?(gwright) → review+
https://hg.mozilla.org/mozilla-central/rev/749f66e5319a
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Depends on: 1237352
You need to log in before you can comment on or make changes to this bug.