1020630 - Desktop Notification doorhanger/notification bar is no longer shown

Status: RESOLVED FIXED

(SeaMonkey :: Passwords & Permissions, defect)

Description

[rsx11m]

+++ This bug was initially created as a clone of Bug #1019986 +++

(Quoting rsx11m from bug 1019986 comment #1)
> Like the patch in bug 998787, this works fine in a SM 2.25, but no
> notification shows up on current trunk builds, which likely is a different
> bug (and considering bug 1019583, it may indicate a more general problem).

The oldest build I have which exhibits the problem is 2.27a1 2014-02-14, built from comm-central changeset 1ce77c2f9bd0 (on Linux). SeaMonkey 2.26 release builds are not affected (Windows/Linux).

Note that the regression range is substantially different from that for the offline-apps issue which I reported in bug 1019583, so this appears to be an independent regression.

Comment 1

[rsx11m]

This is not restricted to the doorhanger, the old notification bar is no longer shown either when browser.doorhanger.enabled is toggled to true. Thus, more likely a backend issue failing to trigger the event showing the notification than the doorhanger implementation itself.

Comment 2

[rsx11m]

Looks like bug 853356 is a good candidate for having caused this regression (bug 998787 comment #14).

Comment 3

[[e-mail]]

Attachment: Proposed patch

Sorry about the long line, but I couldn't decide how to wrap it.

Comment 4

[rsx11m]

Comment on attachment 8434563 [details] [diff] [review]
Proposed patch

WFM on trunk.

Comment 5

[Philip Chee]

Comment on attachment 8434563 [details] [diff] [review]
Proposed patch

> Sorry about the long line, but I couldn't decide how to wrap it.

How about:
    const nsIContentPermissionType = Components.interfaces.nsIContentPermissionType;
    var type = aRequest.types.queryElementAt(0, nsIContentPermissionType).type;

>      const kFeatureKeys = { "geolocation" : "geo",
I think this could be turned into a Map.

Comment 6

[[e-mail]]

Pushed comm-central changeset 37140ce93570.

Comment 7

[Ian Neal]

Comment on attachment 8434563 [details] [diff] [review]
Proposed patch

[Triage Comment]
a=me for 2.28 which is now on c-b

Comment 8

[rsx11m]

Assuming that this is won't-fix for 2.27 as it's not going to be released anyway.

Comment 9

[[e-mail]]

http://hg.mozilla.org/releases/comm-beta/rev/ba7e09de1f81