102070 - many nsIWebNavigation ::LOAD_FLAGS_xxx are ignored when nsIWebNavigation::LoadURI(...) is called.

Status: RESOLVED INVALID

(Core :: DOM: Navigation, defect)

Description

[rpotts (gone)]

when nsIWebNavigation::LoadURI(...) is called, only
nsIWebNavigation::LOAD_FLAGS_NONE is set onto the channel before loading :-(

Comment 1

[rpotts (gone)]

Attachment: quicky patch for the branch

Comment 2

[rpotts (gone)]

This bug is related to bugscape 7180...

I've attached a small patch for the branch.  The real fix is much larger and
involves dealing with all possible combinations of
nsIWebNavigation::LOAD_FLAGS_xxx...

I'll attach a separate patch for the trunk which addresses those issues.

Comment 3

[rpotts (gone)]

moving r=[e-mail] over from bugscape 7180

Comment 4

[vidur (gone)]

Comment on attachment 51168 [details] [diff] [review]
quicky patch for the branch

sr=[e-mail]

Comment 5

[rpotts (gone)]

I talked with nisheeth on the phone and he gave me an a=...  So, i've pushed the
'quick and dirty' patch onto the 0.9.4 branch.

I'm going to keep this bug open until I can land a complete fix onto the trunk.

-- rick

Comment 6

[Nisheeth Ranjan]

Marking PDT+.  The fix has been checked into the branch.

Comment 7

[Jaime Rodriguez, Jr.]

can we pls verify this on the 094 branch?

Comment 8

[lchiang]

It's already been verified on the 094 branch code as commented in the bugscape bug. 

Comment 9

[Marek Z. Jeziorek]

removing topembed (it was fixed on the branch). If there's a separate bug for
the trunk then why is this bug still open?

Comment 10

[rpotts (gone)]

The 'band-aid' patch has only been applied to the branch to address the issues
arising from bugscape 7180.

This bug has been left open to track the progress of the 'real' fix for the trunk.

The 'real' fix will involve quite about of reworking within the DocShell to
consolidate load fiags...

-- rick

Comment 11

[rpotts (gone)]

clearing status whiteboard and keywords - because the related to the branch
patch only.

Comment 12

[rpotts (gone)]

-> 0.9.8

Comment 13

[Cathleen]

topembed+
rick, any progress on long term solution?
do we also need to apply patch to 0.9.9 branch?

- triage team (chofmann, cathleen, marcia)

Comment 14

[Winnie Lam]

any updates?

Comment 15

[Radha on family leave (not reading bugmail)]

I'm not sure if this is still a problem. The loadFlags passed to
nsIWebNavigation::LoadURI() are converted to internal docshell flags and passed
to nsDocShell:LoadURI() using the nsIDocShellLoadInfo object.   Though loadFlags
(3rd argument) passed to nsDocShell::LoadFlags()  from
nsIWebNavigation::LoadURI() is dummy, I think it is hanging around to take care
of some internal calls that avoid using the nsIDocShellLoadInfo object.  Adam
Can you confirm this? I don't believe that docshell ignores any  load flags that
are passed to nsIWebNavigation::LoadURI()

Comment 16

[Radha on family leave (not reading bugmail)]

I do not think this is an issue anymore.