1020751 - Enable GGC on B2G

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Steve Fink [:sfink] [:s:]]

Maybe I'm just bad at searching, but I could not find a bug for GGC on B2G.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Enable GGC on B2G

Looking good: https://tbpl.mozilla.org/?tree=Try&rev=2706ba646a43 (ignore the Hf failure; it's from an unrelated patch I pushed with it.)

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 8434662 [details] [diff] [review]
Enable GGC on B2G

Review of attachment 8434662 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 3

[Steve Fink [:sfink] [:s:]]

https://hg.mozilla.org/integration/b2g-inbound/rev/4c76c940c33e

Comment 4

[Andrew McCreight [:mccr8]]

How big is the nursery on B2G?

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4c76c940c33e

Comment 6

[Terrence Cole [:terrence]]

(In reply to Andrew McCreight [:mccr8] from comment #4)
> How big is the nursery on B2G?

256KiB for the primary allocation; a handful of 4KiB pages for the storebuffer; plus a handful of bytes for management structures on the JSRuntime.

Comment 7

[Terrence Cole [:terrence]]

Actually, just double checked and it looks like we never implemented bug 988369 to make the store buffer smaller on b2g. D'oh! I'll try to make that happen today.

Comment 8

[Terrence Cole [:terrence]]

(In reply to Terrence Cole [:terrence] from comment #7)
> Actually, just double checked and it looks like we never implemented bug
> 988369 to make the store buffer smaller on b2g. D'oh! I'll try to make that
> happen today.

Making that happen made all the tests time out. Since then, bug 1100652 has landed, which should have largely mitigated the catastrophic slowdown with small buffers. I'll try to revisit it this week or next.