Closed Bug 1020751 Opened 6 years ago Closed 6 years ago

Enable GGC on B2G

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: sfink, Assigned: sfink)

References

Details

Attachments

(1 file)

Maybe I'm just bad at searching, but I could not find a bug for GGC on B2G.
Depends on: 983399
Looking good: https://tbpl.mozilla.org/?tree=Try&rev=2706ba646a43 (ignore the Hf failure; it's from an unrelated patch I pushed with it.)
Attachment #8434662 - Flags: review?(terrence)
Depends on: ExactRootingB2G
Comment on attachment 8434662 [details] [diff] [review]
Enable GGC on B2G

Review of attachment 8434662 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8434662 - Flags: review?(terrence) → review+
Depends on: 1022794
How big is the nursery on B2G?
https://hg.mozilla.org/mozilla-central/rev/4c76c940c33e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: needinfo?(terrence)
(In reply to Andrew McCreight [:mccr8] from comment #4)
> How big is the nursery on B2G?

256KiB for the primary allocation; a handful of 4KiB pages for the storebuffer; plus a handful of bytes for management structures on the JSRuntime.
Flags: needinfo?(terrence)
Actually, just double checked and it looks like we never implemented bug 988369 to make the store buffer smaller on b2g. D'oh! I'll try to make that happen today.
Depends on: 988369
Depends on: 1070990
(In reply to Terrence Cole [:terrence] from comment #7)
> Actually, just double checked and it looks like we never implemented bug
> 988369 to make the store buffer smaller on b2g. D'oh! I'll try to make that
> happen today.

Making that happen made all the tests time out. Since then, bug 1100652 has landed, which should have largely mitigated the catastrophic slowdown with small buffers. I'll try to revisit it this week or next.
You need to log in before you can comment on or make changes to this bug.