1021038 - [B2G][Flame][Camera]Previewing pictures taken through Camera app does not display the image

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Josh Schmitt [Joshs]]

Attachment: log.txt

Description:
Previewing Camera pictures does not display the picture.

Repro Steps:
1) Update a Flame to 20140605040202
2) Open the Camera app
3) Take a couple pictures e.g. 5 pictures
4) Select the preview circle

Actual:
The picture preview is not displayed and user cannot easily scroll preview pictures

Expected:
The preview is displayed and user can scroll through pictures

Environmental Variables:
Device: Flame
Build ID: 20140605040202
Gaia: d2cfef555dabab415085e548ed44c48a99be5c32
Gecko: 51b428be6213
Version: 32.0a1 (2.0) 
Firmware Version: v10G-2

User agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Notes:
Repro frequency: 100%
See attached: logcat

Comment 1

[Josh Schmitt [Joshs]]

Issue does NOT repo on 2.0 Buri as there is no preview after taking a picture.

Issue does NOT repro on 1.4 Flame.

1.4 Environmental Variables:
Device: Flame 1.4 MOZ
BuildID: 20140605000203
Gaia: 1f238df7ac68a73a4ceb27391a204c800f38ab1c
Gecko: a7b7f1b579cc
Version: 30.0
Firmware Version: v10G-2

Comment 2

[Justin D'Arcangelo [:justindarc]]

Changes were landed to the shared dependency `media_frame.js` yesterday which caused the preview in the Camera app to break. The following patch is awaiting review which should resolve this:

Bug 1014955 - [Camera] Migrate v1.3T downsampling patches to v1.4/master

Comment 3

[Duane Dixon [:ddixon]]

B2G Inbound Regression Window: 

Last Working: 

Device: Flame 2.0
Build ID: 20140604142546
Gaia: 3f073324e9ac48cce05d24e6f55ffc9b5ec65e18
Gecko: c8dc973cc733
Version: 32.0a1 (2.0) MOZ
Firmware Version: v10G-2

First Broken:

Device: Flame 2.0
Build ID: 20140604143417
Gaia: d2cfef555dabab415085e548ed44c48a99be5c32
Gecko: bd6e2010a4ec
Version: 32.0a1 (2.0) MOZ
Firmware Version: v10G-2

Last Working Gecko and First Broken Gaia
Issue DOES occur here. 
Gaia: d2cfef555dabab415085e548ed44c48a99be5c32
Gecko: c8dc973cc733

Last Working Gaia and First Broken Gecko
Issue DOES NOT occur here. 
Gaia: 3f073324e9ac48cce05d24e6f55ffc9b5ec65e18
Gecko: bd6e2010a4ec


Gaia Pushlog: 
https://github.com/mozilla-b2g/gaia/compare/3f073324e9ac48cce05d24e6f55ffc9b5ec65e18...d2cfef555dabab415085e548ed44c48a99be5c32

Comment 4

[Jason Smith [:jsmith]]

(In reply to Justin D'Arcangelo [:justindarc] from comment #2)
> Changes were landed to the shared dependency `media_frame.js` yesterday
> which caused the preview in the Camera app to break. The following patch is
> awaiting review which should resolve this:
> 
> Bug 1014955 - [Camera] Migrate v1.3T downsampling patches to v1.4/master

We really should back out the cause here (bug 1002593). We shouldn't be landing something half-way done to cause a smoketest regression.

Comment 5

[David Flanagan [:djf]]

We will either land 1014955 this afternoon or back out 1002593. Either way, tomorrow's nightly build should have a working camera app.

Sorry about the bustage, everyone!

Comment 8

[Marcia Knous [:marcia]]

(In reply to David Flanagan [:djf] from comment #5)
> We will either land 1014955 this afternoon or back out 1002593. Either way,
> tomorrow's nightly build should have a working camera app.
> 
> Sorry about the bustage, everyone!

Hello David - this bug is still hanging around and we are close to branching - it looks as if 1014955 still needs to be addressed - can someone take a look at it? Thanks.

Comment 9

[Justin D'Arcangelo [:justindarc]]

Bug 1014955 landed, but was then backed out due to a TBPL test failure. I updated the patch to address what seemed to be the issue. Looking at Gaia-Try now, it still looks like there is a unit test failure in Calendar (unrelated), but I see no test failures for Camera.

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=551af4dee2bd

I'm gonna go ahead and try and land Bug 1014955 (fingers crossed)

Comment 10

[Andrew Stole [:astole]]

Not seeing this camera issue anymore on the latest 2.0 build. The preview is displayed and user can scroll through pictures.

2.0 Environmental Variables:
Device: Flame 2.0
BuildID: 20140609040203
Gaia: 12af93123c5db55212d51fe235d39f21209a1eaa
Gecko: 9305a8ec77fe
Version: 32.0a1
Firmware Version: v10G-2

Comment 11

[Jason Smith [:jsmith]]

https://github.com/mozilla-b2g/gaia/commit/5475755df9d5e16a221eb628b963172fc996f95f

Comment 12

[Justin D'Arcangelo [:justindarc]]

(In reply to Andrew Stole from comment #10)
> Not seeing this camera issue anymore on the latest 2.0 build. The preview is
> displayed and user can scroll through pictures.
> 
> 2.0 Environmental Variables:
> Device: Flame 2.0
> BuildID: 20140609040203
> Gaia: 12af93123c5db55212d51fe235d39f21209a1eaa
> Gecko: 9305a8ec77fe
> Version: 32.0a1
> Firmware Version: v10G-2

Yep, looks like kgrandon merged master into v2.0 yesterday so we should be ok now.

Comment 13

[Josh Schmitt [Joshs]]

Verified fixed on 2.1 Flame 319MB and 2.0 Flame 319MB.

I am able to view the preview after taking pictures.

Enviromental Variables:
----------------------------------------
Device: Flame 2.1
BuildID: 20140905000202
Gaia: 95e9b099aa89ded133e44014dd40b19dc0193c01
Gecko: 92a6bbdfd945
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Environmental Variables:
----------------------------------------------
Device: Flame 2.0
BuildID: 20140905000204
Gaia: 4627014cc5c5eeec894183866d4c57291302f8b8
Gecko: 2fae20afe1fa
Version: 32.0 (2.0)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0