1021055 - Expose Sync client device type in Fennec's tabs provider

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Data Providers, defect)

Description

[Nick Alexander :nalexander [he/him]]

Splitting this off from Bug 899643, since this is purely DB/CP/Sync.  We want to show the device type in the Fennec UI.

This ticket tracks exposing the Sync client record's "device type" in Fennec's clients/tabs content provider.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Add Sync client device type to Fennec's tabs provider. r=rnewman

This is the expedient thing to do.  The right thing to do is to
deprecate Sync's clients database in favour of Fennec's clients table,
but that's a good chunk of work for a small gain.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Add Sync client device type to Fennec's tabs provider. r=rnewman

This is the expedient thing to do.  The right thing to do is to
deprecate Sync's clients database in favour of Fennec's clients table,
but that's a good chunk of work for a small gain.

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8436184 [details] [diff] [review]
Add Sync client device type to Fennec's tabs provider. r=rnewman

Review of attachment 8436184 [details] [diff] [review]:
-----------------------------------------------------------------

I'm carrying over rnewman's r+ from Bug 899643, since this version just includes an additional test, a small tweak (including DEVICE_TYPE in the clients projection), and a typo fix (trailing comma in create).  I'm not going to land until post merge, however, since this does rev a DB and there's some possibility I made an error.  I did test an upgrade and a fresh install, with a sync against the clean DB.

Comment 4

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/281e6fc177c4

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/281e6fc177c4