1021068 - Support new vertical homescreen

Status: RESOLVED FIXED

(Testing Graveyard :: Eideticker, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

A new 'vertical' homescreen has landed in Firefox OS, which breaks Eideticker in several places. A few of these will be taken care of by bug 1019891 and a subsequent gaiatest release (that Eideticker will need to depend on for testing latest mozilla-central builds), however there will also need to be some changes in Eideticker itself.

The code to start B2G includes a wait, which is not compatible with the new homescreen. If we can, we should use GaiaDevice.start_b2g, which handles the new homescreen. Alternatively, we should update the wait to be compatible.

The code to look for app icons is heavily dependent on the homescreen code. There's no longer a dock or 'pages', and all icons are shown in a scrolling list. We therefore need to scroll the appropriate icon into view and then work out the location as an offset of the viewable area.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

It looks like our workaround to continue using the old homescreen may not be supported any longer. I have a working patch to update to the new vertical homescreen, so I'll get something up for review soon.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Link to Github pull-request: https://github.com/mozilla/eideticker/pull/12

This turned out to be a bit easier than I expected. I'm hoping this will fix the current failures in CI.

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8500011 [details] [review]
Link to Github pull-request: https://github.com/mozilla/eideticker/pull/12

Looks good, does it work ok on 2.0?

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to William Lachance (:wlach) from comment #3)
> Comment on attachment 8500011 [details] [review]
> Link to Github pull-request: https://github.com/mozilla/eideticker/pull/12
> 
> Looks good, does it work ok on 2.0?

Thanks for prompting me to check this! It does work but I needed to bump the version number for gaiatest-v2.0 to 0.3 and release. This included a small change to the JavaScript for killing apps, which failed when we had the vertical homescreen in use. I've now landed the fix to use vertical homescreen: https://github.com/mozilla/eideticker/commit/acde0e1ffeb21076d6fbc70df347720fc71b69eb

Note that this does break compatibility for v1.3, however we're not currently running any tests on this version. If we need to restore support for this version then it can be done, however I suspect it makes more sense to drop support for v1.3 and remove the associated code. What do you think Will?

I'm going to leave this open until I see some passing results. Setting a needinfo for myself.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Looks like it's fixed now: http://eideticker.mozilla.org/videos/50e885404d5a11e482ce10ddb19e8514.webm

Comment 6

[William Lachance (:wlach)]

I absolutely think we should drop 1.3, there's very little chance we'll want to use eideticker with that branch again.

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to William Lachance (:wlach) from comment #6)
> I absolutely think we should drop 1.3, there's very little chance we'll want
> to use eideticker with that branch again.

I've raised bug 1079132 for this.