servo builder git clean should clean ignored files too

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jack, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Can we make it run `git clean -fxd` instead of git clean -ffd`?
(Assignee)

Comment 1

4 years ago
Aki, there's currently no support for this in GittoolVCS. Any thoughts?
Flags: needinfo?(aki)
(In reply to Ben Hearsum [:bhearsum] from comment #1)
> Aki, there's currently no support for this in GittoolVCS. Any thoughts?

There's vcs_config['clean'], which creates a --clean for gittool.py.
That seems to hook into http://hg.mozilla.org/build/tools/annotate/524bdee72020/lib/python/util/git.py#l133 , so we might want to ask the author about changing the options here.

Oh, that's you! :)  Any objections to changing that to -f -x -d instead of -f -f -d, Ben? :)  (or -f -f -x -d)
Flags: needinfo?(aki)
(Assignee)

Comment 3

4 years ago
Created attachment 8435179 [details] [diff] [review]
clean-harder.diff

(In reply to Aki Sasaki [:aki] from comment #2)
> (In reply to Ben Hearsum [:bhearsum] from comment #1)
> > Aki, there's currently no support for this in GittoolVCS. Any thoughts?
> 
> There's vcs_config['clean'], which creates a --clean for gittool.py.
> That seems to hook into
> http://hg.mozilla.org/build/tools/annotate/524bdee72020/lib/python/util/git.
> py#l133 , so we might want to ask the author about changing the options here.
> 
> Oh, that's you! :)  Any objections to changing that to -f -x -d instead of
> -f -f -d, Ben? :)  (or -f -f -x -d)

Oops :)

This patch will do it. We still want -f -f because that's for submodules, whic we also want to clean.
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
(Assignee)

Updated

4 years ago
Attachment #8435179 - Flags: review?(aki)
Attachment #8435179 - Flags: review?(aki) → review+
(Assignee)

Comment 4

4 years ago
Comment on attachment 8435179 [details] [diff] [review]
clean-harder.diff

Should be fixed for any newly started jobs.
Attachment #8435179 - Flags: checked-in+
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.