Closed
Bug 1021117
Opened 10 years ago
Closed 10 years ago
mozlog.structured.formatters should include a formatter that speaks TBPL
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla32
People
(Reporter: chmanchester, Assigned: chmanchester)
References
Details
Attachments
(1 file, 3 obsolete files)
|
4.81 KB,
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
jgraham wrote a formatter that works with TBPL that was borrowed for bug 886570, and a version of it is in use in the wpt mozharness script. Let's land it in mozlog.structured. It might also be nice to have a set of tests that log with this formatter and test the output against various regex in the wild.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8435092 -
Flags: review?(james)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → cmanchester
Status: NEW → ASSIGNED
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8435092 [details] [diff] [review] Add legacy tbpl formatter to mozlog.structured.formatters Review of attachment 8435092 [details] [diff] [review]: ----------------------------------------------------------------- You also need to modify commandline.py so that you can use the new formatter. ::: testing/mozbase/mozlog/mozlog/structured/formatters/machformatter.py @@ +167,5 @@ > result = s > > return result > > +class LegacyTBPLFormatter(BaseMachFormatter): I think this should be in its own file.
Attachment #8435092 -
Flags: review?(james) → review-
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8435144 -
Flags: review?(james)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8435092 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8435144 -
Flags: review?(james)
|
|
Assignee | |
Comment 4•10 years ago
|
||
The formatter should be responsible for appending newlines.
Attachment #8435287 -
Flags: review?(james)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8435144 -
Attachment is obsolete: true
|
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8435287 [details] [diff] [review] Add legacy tbpl formatter to mozlog.structured.formatters I might be tempted to s/Legacy//g but otherwise it's fine.
Attachment #8435287 -
Flags: review?(james) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
Change "LegacyTBPLFormatter" to "TbplFormatter"
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8435287 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8435853 -
Flags: review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7c75329ae84
Keywords: checkin-needed
|
|
||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d7c75329ae84
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•