Closed Bug 1021117 Opened 6 years ago Closed 6 years ago

mozlog.structured.formatters should include a formatter that speaks TBPL

Categories

(Testing :: Mozbase, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla32

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(1 file, 3 obsolete files)

jgraham wrote a formatter that works with TBPL that was borrowed for bug 886570, and a version of it is in use in the wpt mozharness script. Let's land it in mozlog.structured.

It might also be nice to have a set of tests that log with this formatter and test the output against various regex in the wild.
Assignee: nobody → cmanchester
Status: NEW → ASSIGNED
Comment on attachment 8435092 [details] [diff] [review]
Add legacy tbpl formatter to mozlog.structured.formatters

Review of attachment 8435092 [details] [diff] [review]:
-----------------------------------------------------------------

You also need to modify commandline.py so that you can use the new formatter.

::: testing/mozbase/mozlog/mozlog/structured/formatters/machformatter.py
@@ +167,5 @@
>              result = s
>  
>          return result
>  
> +class LegacyTBPLFormatter(BaseMachFormatter):

I think this should be in its own file.
Attachment #8435092 - Flags: review?(james) → review-
Attachment #8435092 - Attachment is obsolete: true
Attachment #8435144 - Flags: review?(james)
The formatter should be responsible for appending newlines.
Attachment #8435287 - Flags: review?(james)
Attachment #8435144 - Attachment is obsolete: true
Comment on attachment 8435287 [details] [diff] [review]
Add legacy tbpl formatter to mozlog.structured.formatters

I might be tempted to s/Legacy//g but otherwise it's fine.
Attachment #8435287 - Flags: review?(james) → review+
Change "LegacyTBPLFormatter" to "TbplFormatter"
Attachment #8435287 - Attachment is obsolete: true
Attachment #8435853 - Flags: review+
Keywords: checkin-needed
Blocks: 886570
https://hg.mozilla.org/mozilla-central/rev/d7c75329ae84
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.