1021133 - Header resizing for long strings fails for some labels

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: Settings (xh)

Filing a new, less crowded bug to investigate this.

I flashed my keon with Gecko+Gaia a few minutes ago: header resizing is definitely working, but it's also failing for at least a couple of labels (I'm using xh for testing).

See screenshot: #1 and #3 are truncated, #2 is not, even if it's probably longer.
My only explanation is the hyphen in the string.

This probably doesn't happen on Flame because screen is large enough to fit the original string without resizing it.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

The issue is that our canvas.measureText function doesn't take into account fontStyle. Headers are all italic, and since italic fonts are slightly wider than normal fonts, there are cases where our re-sizing still produces overflow. I'm patching FontSizeUtils now to use Font Style.

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [Pull Request] make getFontWidth fontStyle aware, default to italic

Guillaume will you have a look?

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

My forked Travis: https://travis-ci.org/mikehenrty/gaia/builds/26989099

Gaia-Try: https://tbpl.mozilla.org/?tree=Gaia-Try&rev=ba0901cd81f9

Waiting for green.

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/0399ef45c7fb271e75cfdcc8c163c27ab6d0acfa