1021258 - Prototype mutation warning no longer displays when invoking __proto__ setter

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bobby Holley (:bholley)]

This is a regression from bug 992958. Patch coming up.

Comment 1

[Bobby Holley (:bholley)]

(Tracking given proximity to the merge)

Comment 2

[Bobby Holley (:bholley)]

Attachment: Restore the __proto__ mutation warning for __proto__ sets. v1

Comment 3

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b809afd1cea

Comment 4

[[e-mail]]

Comment on attachment 8435277 [details] [diff] [review]
Restore the __proto__ mutation warning for __proto__ sets. v1

>+        window[0].eval('var foo = {}; Object.setPrototypeOf(foo, {});' +
>+                       'var bar = {}; Object.getPrototypeOf(bar, {});');
Typo? (I assume here your intention is to expect one mutation warning for two prototype sets.)

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/257a99604e30 for somehow breaking Android m8: https://tbpl.mozilla.org/php/getParsedLog.php?id=41162065&tree=Mozilla-Inbound

Comment 6

[Bobby Holley (:bholley)]

That is one of the most bizarre failures I've ever seen.

Let's figure out whether it relates to the code change or to the test (somehow).

Comment 7

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=8f6334293b27

Comment 8

[Ed Morley [:emorley]]

(In reply to Wes Kocher (:KWierso) from comment #5)
> Backed out in
> https://hg.mozilla.org/integration/mozilla-inbound/rev/257a99604e30 for
> somehow breaking Android m8:
> https://tbpl.mozilla.org/php/getParsedLog.php?id=41162065&tree=Mozilla-
> Inbound

It turns out the test is broken & this landing just bumped it from one mochitest chunk to another causing it to fail (since that test must rely on previous state; sigh). The test will be disabled in bug 1021644, after which this can reland :-)

Comment 9

[Ed Morley [:emorley]]

Relanded:
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/31c707eb3a4b

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/31c707eb3a4b