Closed Bug 1021285 Opened 5 years ago Closed 5 years ago

Wallpaper Picker Screen needs a few updates

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

x86
macOS
defect
Not set

Tracking

(b2g-v2.0 verified, b2g-v2.1 verified)

VERIFIED FIXED
2.0 S4 (20june)
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: padamczyk, Assigned: dmarcos)

References

Details

(Whiteboard: [systemsfe])

Attachments

(3 files)

Attached image 2014-06-05-10-48-09.png
+ The small 30x30 icons have terrible scaling, all jagged
+ The wallpaper app should have an icon, it looks really out of place without one
Component: Gaia::Homescreen → Gaia::System::Window Mgmt
QA Whiteboard: [VH-FL-blocking-]
QA Whiteboard: [VH-FL-blocking-] → [VH-FL-blocking-][VH-FC-blocking+]
Do we have a wallpaper icon?
Flags: needinfo?(hhuang)
Attached file wallpaper icons.zip
These are the wallpaper icons. I think this was working, but we must've regressed it with some icon changes recently.
Flags: needinfo?(hhuang)
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S4 (20june)
Assignee: nobody → dmarcos
Attached file Pull request
The path to the wallpaper icons was in incorrect in the manifest
Attachment #8438821 - Flags: review?(kgrandon)
Sounds good, let's land this and follow-up with the resolution in another bug. We no longer have smaller assets, but perhaps we could add them again if needed.

I've filed bug 1024255 to handle the activity icon scaling problem.
Comment on attachment 8438821 [details] [review]
Pull request

Thanks!
Attachment #8438821 - Flags: review?(kgrandon) → review+
Landed: https://github.com/mozilla-b2g/gaia/commit/9ff71314687b4a5311b8cb1628b4e4e43ba16554
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 8438821 [details] [review]
Pull request

This is a rather bad experience, and is needed for the vertical homescreen. Thanks!
Attachment #8438821 - Flags: approval-gaia-v2.0?(bbajaj)
Attachment #8438821 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Verified on master. Wallpaper has now an icon.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.