Closed Bug 1021343 Opened 6 years ago Closed 6 years ago

[Settings] Duplicated Homescreen entry

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(b2g-v2.0 verified, b2g-v2.1 verified)

VERIFIED FIXED
2.0 S4 (20june)
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: raniere, Assigned: kgrandon)

References

Details

(Keywords: regression, Whiteboard: [p=2],[systemsfe])

Attachments

(4 files)

Steps to reproduce:

1. Open Settings app
2. Scroll down until "Account Management" shows at the bottom of the screen.
	 
Actual results:

You should see the entries:

- Homescreen
- Notifications
- Date & Time
- Language
- Homescreens
- Keyboards

Notice that "Homescreen" is duplicated.
	 
Expected results:

See the entries:

- Homescreen
- Notifications
- Date & Time
- Language
- Homescreens
- Keyboards

Without duplicated "Homescreen".

Environment information:

- OS version: 2.0.0.0-prerelease
- Hardware revision: qcom
- Platform version: 31.0a1
- Build Identifier: 20140422082646
- Git commit info: 2014-06-05 20:54:15 bc40fdbe
We had this fixed, not sure what caused it to appear again.
Component: Gaia::Settings → Gaia::Build
Keywords: regression
Assignee: nobody → kgrandon
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Whiteboard: [p=2],[systemsfe]
Target Milestone: --- → 2.0 S4 (20june)
Attached file Github pull request
Hey guys, anyone got time for a review? I think what happened is a commit got backed out that this one was working with?? At least I saw something about a BUILD_STAGE thing getting backed and and this not working. At least we have a test now.
Attachment #8440249 - Flags: review?(yurenju.mozilla)
Attachment #8440249 - Flags: review?(crdlc)
Comment on attachment 8440249 [details] [review]
Github pull request

LGTM r=me although Yurenju is the expert here
Attachment #8440249 - Flags: review?(crdlc) → review+
Comment on attachment 8440249 [details] [review]
Github pull request

r=me too, thanks Kevin to fix it and this test case.
Attachment #8440249 - Flags: review?(yurenju.mozilla) → review+
Landed: https://github.com/mozilla-b2g/gaia/commit/85f1ceadb72e9373f80b67619c42f4f9da4f0657
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment on attachment 8440249 [details] [review]
Github pull request

This is a rather simple patch that's necessary for the vertical homescreen and has been well tested.
Attachment #8440249 - Flags: approval-gaia-v2.0?(bbajaj)
Keywords: verifyme
Attachment #8440249 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Status: RESOLVED → VERIFIED
This issue is verified fixed on Flame 2.1 

Results: Homescreen is not duplicated in settings

Flame 2.1 

Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141125001201
Gaia: 1bdd49770e2cb7a7321e6202c9bf036ab5d8f200
Gecko: db893274d9a6
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Keywords: verifyme
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.