1021362 - /msg foo tries to send the message "foo" to a blank nick

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

Typing |/msg  foo| (two spaces between /msg and foo) in a conversation window is expected to open a conversation with foo, but instead tries to send the message "foo" to a blank nick. This results in the following error:

Timestamp: 06/06/14 5:25:55 am
Error: ERR_NOTEXTTOSEND: No text to send for PRIVMSG.
Source File: resource://gre/modules/ircBase.jsm
Line: 1127
Source Code:
prpl-irc: ircBase.commands[412]

This makes me think that when sending the raw message, IRC sees it as sending a message to a nick "foo" but there's no message (I'm thinking the line is something like |PRIVMSG  foo|).

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch

Trim leading whitespace in messageCommand().

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8435396 [details] [diff] [review]
Patch

Review of attachment 8435396 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/protocols/irc/ircCommands.jsm
@@ +43,5 @@
>  // aMsg is <user> <message>
>  // aReturnedConv is optional and returns the resulting conversation.
>  function messageCommand(aMsg, aConv, aReturnedConv) {
> +  // Trim leading whitespace.
> +  aMsg = aMsg.replace(/^\s+/, "");

Seems that there is a trimLeft function. I imagine this has better performance than a regexp: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/trimLeft

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch v2 - use trimLeft

Comment 4

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/comm-central/rev/4775099e4d95