1021380 - [flame][contacts] icons when contact list is empty seem fuzzy

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Tiffanie Shakespeare [:tif]]

Attachment: Contacts screen

STR 
1. Have no contacts saved
2. Launch Contacts app

Expected
Crisp icons

Actual
They seem fuzzy

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Helen,
can you help?

Comment 2

[Helen Huang [:HHuang]]

Hi Pavel, 

Can you help to locate those images in Gaia? I can't find them.
Thanks!

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Helen, 
sure ... I just realize that you provide me `settings_small_ico_` instead of `settings_small_ico` images in Bug 1011696 ... However we need all versions of `plus_small_ico` image ... you can find the images here:
https://github.com/mozilla-b2g/gaia/tree/master/apps/communications/contacts/style/images
- plus_small_ico.png
- [e-mail]
- [e-mail]
- [e-mail]

Hope this help you :)

Comment 4

[Helen Huang [:HHuang]]

Attachment: Contacts fuzzing images.zip

Hi Pavel,

Sorry for the mistake in Bug 1011696.
I've attached all versions of `plus_small_ico` images, and `settings_small_ico' images again. Please replace them.

Could you also help to remove the following wrong images?
- [e-mail]
- [e-mail]
- [e-mail]

Thanks!

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

The images are compressed now

Comment 6

[Helen Huang [:HHuang]]

Attachment: images_bluetooth_icon.zip

Hey, 

I found there are two images look broken, [e-mail] and [e-mail], so I modified them.

Please help to replace it. Thanks!

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Done :)

Comment 8

[Jose Manuel Cantera]

Comment on attachment 8439792 [details] [review]
patch for Gaia/master

thanks Pavel

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/3325818b2751daf67b584714dc283bf36765a5ef

Comment 10

[Helen Huang [:HHuang]]

Comment on attachment 8439792 [details] [review]
patch for Gaia/master

Bug was fixed.